Bug 31903 - Article requests: Edit URLs link missing in the New tab
Summary: Article requests: Edit URLs link missing in the New tab
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Marcel de Rooy
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-21 09:24 UTC by Marcel de Rooy
Modified: 2023-12-28 20:44 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.08, 21.11.15


Attachments
Bug 31903: Fix missing Edit URL link (1.77 KB, patch)
2022-10-21 09:31 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 31903: Fix missing Edit URL link (1.95 KB, patch)
2022-10-21 13:34 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2022-10-21 09:24:43 UTC
Trivial fix.
The format should be passed along like we do for the other tables.
Found in 21.11.
Comment 1 Marcel de Rooy 2022-10-21 09:31:37 UTC
Created attachment 142313 [details] [review]
Bug 31903: Fix missing Edit URL link

We need to pass format too for New tab (see Pending/Processing).

Test plan:
Include SCAN format in AR preferences. Check circ rules too.
Add a new request.
Check Circulation, Article requests, New tab. Verify that the Actions
menu for a single row (!) does contain the option now.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2022-10-21 09:32:08 UTC
Trivial one-liner, not widely used (yet). Self SO
Comment 3 Katrin Fischer 2022-10-21 13:31:17 UTC
Took me a little bit to find the missing piece:

* Set ArticleRequestsSupportedFormats to PHOTOCOPY|SCAN
* Create an article request for a digital copy.

Maybe we could dig out the older bugs here and mark them needs documenting? Appears to be an interesting feature!
Comment 4 Katrin Fischer 2022-10-21 13:34:03 UTC
Created attachment 142366 [details] [review]
Bug 31903: Fix missing Edit URL link

We need to pass format too for New tab (see Pending/Processing).

Test plan:
* Include SCAN format in ArticleRequestSupportedFormats system preferences.
* Check circ rules to allow article requests.
* Add a new request for digital copy and another for photocopy.
* Check Circulation - Article requests - New tab.
* Verify that the Actions menu for a single row for the digital copy
  does contain the "Edit URL(s)" option now.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Amended test plan.
Comment 5 Tomás Cohen Arazi 2022-10-24 14:56:13 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 6 Lucas Gass 2022-12-05 22:28:22 UTC
Backported to 22.05.x for upcoming 22.05.08
Comment 7 Arthur Suzuki 2022-12-16 15:02:44 UTC
applied to 21.11 for 21.11.15
Comment 8 wainuiwitikapark 2023-03-15 01:04:00 UTC
Not backported to 21.05.x