Bug 31940 - Add page-section to admin > library groups area
Summary: Add page-section to admin > library groups area
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Martin Renvoize
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 30952
Blocks: 31757
  Show dependency treegraph
 
Reported: 2022-10-24 11:32 UTC by Martin Renvoize
Modified: 2023-12-28 20:43 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31940: Add page-section to library-groups (1.31 KB, patch)
2022-10-24 11:34 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 31940: Add page-section to library-groups (1.37 KB, patch)
2022-10-24 19:48 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2022-10-24 11:32:44 UTC
The library groups administration area needs page-section classes adding.
Comment 1 Martin Renvoize 2022-10-24 11:34:30 UTC
Created attachment 142489 [details] [review]
Bug 31940: Add page-section to library-groups

This patch adds the page-section div around each library-groups table.

Test plan
1) Check that the 'card' views appear appropriates on the library groups
   maangement page
Comment 2 Martin Renvoize 2022-10-24 11:35:05 UTC
I don't really like how the tables display all different widths.. but that's a bug for another day I reckon.
Comment 3 Katrin Fischer 2022-10-24 19:48:48 UTC
Created attachment 142563 [details] [review]
Bug 31940: Add page-section to library-groups

This patch adds the page-section div around each library-groups table.

Test plan
1) Check that the 'card' views appear appropriates on the library groups
   maangement page

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Katrin Fischer 2022-10-24 19:49:55 UTC
Small easy fix, passing QA directly.
Comment 5 Tomás Cohen Arazi 2022-10-24 20:26:58 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!