Bug 31950 - Page section on library view is too wide / not aligned with toolbar
Summary: Page section on library view is too wide / not aligned with toolbar
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Jacob O'Mara
QA Contact: Katrin Fischer
URL:
Keywords: Academy
Depends on: 31939
Blocks:
  Show dependency treegraph
 
Reported: 2022-10-24 15:16 UTC by Katrin Fischer
Modified: 2023-06-08 22:32 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.02


Attachments
BUG 31950: Amend page-section width and alignment (1.13 KB, patch)
2022-12-15 19:22 UTC, Jacob O'Mara
Details | Diff | Splinter Review
Bug 31950: Amend page-section width and alignment (1.13 KB, patch)
2022-12-19 10:06 UTC, Jacob O'Mara
Details | Diff | Splinter Review
Bug 31950: Amend page-section width and alignment (1.19 KB, patch)
2022-12-19 16:20 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 31950: Amend page-section width and alignment (1.24 KB, patch)
2023-01-16 19:41 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-10-24 15:16:50 UTC
When viewing a library (click on the library name in admin > libraries) the page section is too wide and not aligning with the toolbar above.
Comment 1 Katrin Fischer 2022-10-24 15:33:32 UTC
It's much easier to see with the patch from bug 31939 and this in IntranetUserCSS:

body { background-color: silver; }
Comment 2 Jacob O'Mara 2022-12-15 19:22:33 UTC
Created attachment 144636 [details] [review]
BUG 31950: Amend page-section width and alignment

Test Plan:
Navigate to Admin -> Libraries and click on a Library
Observe that the page-section is too wide and not aligned
Apply Patch
Observe that page-section is now the correct width
Comment 3 Lucas Gass 2022-12-16 17:10:45 UTC
A nice simple solution! One problem from the QA tool. It is pretty picky about how you format the title of your bug:

BUG 31950: Amend page-section width and alignment

should be 

Bug 31950: Amend page-section width and alignment
Comment 4 Jacob O'Mara 2022-12-19 10:06:01 UTC
Created attachment 144712 [details] [review]
Bug 31950: Amend page-section width and alignment

Test Plan:
Navigate to Admin -> Libraries and click on a Library
Observe that the page-section is too wide and not aligned
Apply Patch
Observe that page-section is now the correct width
Comment 5 Lucas Gass 2022-12-19 16:20:22 UTC
Created attachment 144717 [details] [review]
Bug 31950: Amend page-section width and alignment

Test Plan:
Navigate to Admin -> Libraries and click on a Library
Observe that the page-section is too wide and not aligned
Apply Patch
Observe that page-section is now the correct width

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 6 Katrin Fischer 2023-01-16 19:41:34 UTC
Created attachment 145339 [details] [review]
Bug 31950: Amend page-section width and alignment

Test Plan:
Navigate to Admin -> Libraries and click on a Library
Observe that the page-section is too wide and not aligned
Apply Patch
Observe that page-section is now the correct width

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Katrin Fischer 2023-01-16 19:41:59 UTC
Nice one, Jacob!
Comment 8 Martin Renvoize 2023-01-17 09:40:32 UTC
Nice work everyone!

Pushed to 23.05.x for the next release
Comment 9 Matt Blenkinsop 2023-01-17 15:11:37 UTC
Nice work everyone!

Pushed to stable for 22.11.x