Bug 31955 - Add page-section to additional fields (admin)
Summary: Add page-section to additional fields (admin)
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Lucas Gass
QA Contact: Katrin Fischer
URL:
Keywords: Academy
Depends on: 30952
Blocks: 31757
  Show dependency treegraph
 
Reported: 2022-10-24 16:20 UTC by Katrin Fischer
Modified: 2023-12-28 20:43 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31955: Add page-section div to additional-fields.tt (4.76 KB, patch)
2022-10-24 17:47 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 31955: Add page-section div to additional-fields.tt (4.82 KB, patch)
2022-10-24 18:15 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-10-24 16:20:52 UTC
The table for configured additional fields should have some background (page-section).
Comment 1 Lucas Gass 2022-10-24 17:47:27 UTC
Created attachment 142539 [details] [review]
Bug 31955: Add page-section div to additional-fields.tt

To test:
1. Apply patch
2. Look at Administration > Additional fields.
3. Each of the 4 tables should have a page-section div around it:

    Order baskets (aqbasket)
    Subscriptions (subscription)
    Account lines (credit) (accountlines:credit)
    Account lines (debit) (accountlines:debit)

Note: There are some indentation changes.
Comment 2 Katrin Fischer 2022-10-24 18:14:09 UTC
This is great. Wondering: should we have a page-section here too?
http://localhost:8081/cgi-bin/koha/admin/additional-fields.pl
Comment 3 Katrin Fischer 2022-10-24 18:15:53 UTC
Created attachment 142546 [details] [review]
Bug 31955: Add page-section div to additional-fields.tt

To test:
1. Apply patch
2. Look at Administration > Additional fields.
3. Each of the 4 tables should have a page-section div around it:

    Order baskets (aqbasket)
    Subscriptions (subscription)
    Account lines (credit) (accountlines:credit)
    Account lines (debit) (accountlines:debit)

Note: There are some indentation changes.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Katrin Fischer 2022-10-24 18:16:17 UTC
Moving to PQA directly!
Comment 5 Tomás Cohen Arazi 2022-10-24 18:45:24 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!