I'm having trouble translating the sentences in branches.tt where it says the the default is a system preference. For example, line ~210 [% IF ( CAN_user_parameters_manage_sysprefs ) %] Default: <a target="_blank" href="/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=ILLDefaultStaffEmail">ILLDefaultStaffEmail</a> system preference [% ELSE %] Default: ILLDefaultStaffEmail system preference [% END %] It comes out like this in translation msgid "%s Default: " msgid "ILLDefaultStaffEmail" msgid "" "system preference %s Default: ILLDefaultStaffEmail system preference %s " However, in French, the order of the words should be inverted, e.g. ILLDefaultStaffEmail system preference becomes system preference ILLDefaultStaffEmail. Can we modify the tt so that we get the whole sentence, or a %s that we can play with to change the order of the words?
Created attachment 145112 [details] [review] Bug 31957: Improve translatability of text containing links on libraries admin page The libraries administration page has several links to system preferences that appear within sentences or with other text around it. To make translations easier, we need to make sure that those links don't break context. To test: * Activate IllModule (so we can see the ILL staff email setting) * Go to administration > libraries * Verify that the links for those settings show correctly * Reply-to * Return-Path * Ill staff email * MARC organization code * Apply patch * Verify links still work and show unchanged If you are familiar with the process, you can also make sure the strings now show up on po files as expected: https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_in_your_installation
Created attachment 145113 [details] [review] Bug 31957: Improve translatability of text containing links on libraries admin page The libraries administration page has several links to system preferences that appear within sentences or with other text around it. To make translations easier, we need to make sure that those links don't break context. To test: * Activate IllModule (so we can see the ILL staff email setting) * Go to administration > libraries * Verify that the links for those settings show correctly * Reply-to * Return-Path * Ill staff email * MARC organization code * Apply patch * Verify links still work and show unchanged If you are familiar with the process, you can also make sure the strings now show up on po files as expected: https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_in_your_installation https://bugs.koha-community.org/show_bug.cgi?id=31954
Hi Katrin! Thanks for looking at this one! I tested and it works well. However, it does add unnecessary strings in the .po file, such as #. %1$s: IF ( CAN_user_parameters_manage_sysprefs ) #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt:194 #, fuzzy, c-format msgid "%s [%% SET pref_ILLDefaultStaffEmail_link = '" msgstr "%s %s [%% SET pref_MARCOverlayRules_link = '" (ignore the msgstr, i's obviously wrong hehe!) I tried to remove the patch and reupdate the files and these lines disappear, so it's definitely the patch that adds them. I tried adding spans to indicate the limits of the translatable string, but it doesn't remove the SET blabla lines from the po file. Caroline
I saw these extra strings, but I am not sure if we can avoid them. You might have to pick your poison... I copied this solution from something Jonathan did for Curbside pickups, not sure if there is any other way right now. And this one is not from this patch set: msgstr "%s %s [%% SET pref_MARCOverlayRules_link = '"
I can't find the bug, but I'm pretty sure Frido did something to remove TT comments from translatable strings in one bug I had... I found bug 18682 but it's not the same I remember.
(In reply to Caroline Cyr La Rose from comment #5) > I can't find the bug, but I'm pretty sure Frido did something to remove TT > comments from translatable strings in one bug I had... > > I found bug 18682 but it's not the same I remember. Good thinking, maybe Frido can help!
Created attachment 145161 [details] [review] Bug 31957: (follow-up) Further improve translations With the previous attempt, we ended up with some TT constructs in the po files. This will hopefully avoid that.
Created attachment 145162 [details] [review] Bug 31957: Improve translatability of text containing links on libraries admin page The libraries administration page has several links to system preferences that appear within sentences or with other text around it. To make translations easier, we need to make sure that those links don't break context. To test: * Activate IllModule (so we can see the ILL staff email setting) * Go to administration > libraries * Verify that the links for those settings show correctly * Reply-to * Return-Path * Ill staff email * MARC organization code * Apply patch * Verify links still work and show unchanged If you are familiar with the process, you can also make sure the strings now show up on po files as expected: https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_in_your_installation https://bugs.koha-community.org/show_bug.cgi?id=31954
Created attachment 145163 [details] [review] Bug 31957: (follow-up) Further improve translations With the previous attempt, we ended up with some TT constructs in the po files. This will hopefully avoid that.
Created attachment 145164 [details] [review] Bug 31957: Improve translatability of text containing links on libraries admin page The libraries administration page has several links to system preferences that appear within sentences or with other text around it. To make translations easier, we need to make sure that those links don't break context. To test: * Activate IllModule (so we can see the ILL staff email setting) * Go to administration > libraries * Verify that the links for those settings show correctly * Reply-to * Return-Path * Ill staff email * MARC organization code * Apply patch * Verify links still work and show unchanged If you are familiar with the process, you can also make sure the strings now show up on po files as expected: https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_in_your_installation https://bugs.koha-community.org/show_bug.cgi?id=31954 Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Created attachment 145165 [details] [review] Bug 31957: (follow-up) Further improve translations With the previous attempt, we ended up with some TT constructs in the po files. This will hopefully avoid that. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Created attachment 146513 [details] [review] Bug 31957: Improve translatability of text containing links on libraries admin page The libraries administration page has several links to system preferences that appear within sentences or with other text around it. To make translations easier, we need to make sure that those links don't break context. To test: * Activate IllModule (so we can see the ILL staff email setting) * Go to administration > libraries * Verify that the links for those settings show correctly * Reply-to * Return-Path * Ill staff email * MARC organization code * Apply patch * Verify links still work and show unchanged If you are familiar with the process, you can also make sure the strings now show up on po files as expected: https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_in_your_installation https://bugs.koha-community.org/show_bug.cgi?id=31954 Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 146514 [details] [review] Bug 31957: (follow-up) Further improve translations With the previous attempt, we ended up with some TT constructs in the po files. This will hopefully avoid that. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 146688 [details] [review] Bug 31957: (QA follow-up) Add missing filters Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to 22.11.x for next release
Backported to 22.05.x for upcoming 22.05.11
applied to 21.11.x for upcoming 21.11.19
Not backporting to 21.05.x