Bug 3197 - Problem editing Authority MARC Subfield Structure: no "subfield code" box
Summary: Problem editing Authority MARC Subfield Structure: no "subfield code" box
Status: CLOSED WORKSFORME
Alias: None
Product: Koha
Classification: Unclassified
Component: MARC Authority data support (show other bugs)
Version: Main
Hardware: Other All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Colin Campbell
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-07 01:32 UTC by Chris Cormack
Modified: 2012-10-26 00:41 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
adding patch from colin.campbell@ptfs-europe.com (3.25 KB, patch)
2009-05-08 00:35 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:07:34 UTC


---- Reported by repke@xs4all.nl 2009-05-07 13:32:48 ----

Editing Authority MARC Subfield Structure is not possible.

As follows, including screenshots.  Might be related to http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2917. 

Here is the point in the editing steps where everything is still fine after adding a new tag 109 (as test example):   
http://screencast.com/t/Gl2yXBzJXpD
Obviously there is no Subfield list yet.

After clicking "Edit subfields", things go wrong because the "subfield code" box is missing to type in the subfield (0-9, a-z) you wish to add.
Here is the screenshot: 
http://screencast.com/t/SMSWqpqrllN

If you do go on from this point and do a Save Changes anyway, Koha messes up and introduces a number of @ subfields in tag 109.



---- Additional Comments From colin.campbell@ptfs-europe.com 2009-05-07 14:01:26 ----

Patch submitted to patches@koha.org



---- Additional Comments From paul.poulain@biblibre.com 2009-05-07 14:09:52 ----

hi Colin,

thanks for the patch, but just a note : when you send a bug, don't mark it "FIXED", just change the priority to "PATCH-Sent". Then the Release Manager will test & apply it and change the resolution to FIXED.



---- Additional Comments From mason@kohaaloha.com 2009-05-08 00:35:09 ----

Created an attachment
adding patch from colin.campbell@ptfs-europe.com 





---- Additional Comments From gmcharlt@gmail.com 2009-05-08 12:18:57 ----

Patch pushed.  The bug as reported appears fixed, but there are a couple problems remaining with this form:

[1] When you add a new subfield when the repeatable and/or mandatory checkboxes ticked, those two settings are not saved.  To make a new subfield mandatory or repeatable, you have to edit it again.

[2] There are a bug of XHTML validation warnings.

Perhaps you could take a look at these, Colin?



---- Additional Comments From colin.campbell@ptfs-europe.com 2009-05-08 14:35:10 ----

Checked the marc subfields entry and the same problem with setting mandatory and repeatable on a New subfield exists there. Will need to fix both



---- Additional Comments From gmcharlt@gmail.com 2009-05-08 19:46:35 ----

Changing severity to normal - this bug is not a blocker.



---- Additional Comments From gmcharlt@gmail.com 2009-06-06 19:54:30 ----

Pushed patch fixing most of the XHTML validation warnings.  Some remain, as well as the problem storing the repeatable and mandatory flags when entering a new subfield.



---- Additional Comments From colin.campbell@ptfs-europe.com 2009-06-23 13:33:01 ----

The original bug seems to have returned in latest HEAD. 
Giving the code a serious going over with an eye to fixing the functionality and future maintainability



---- Additional Comments From gmcharlt@gmail.com 2009-06-23 13:45:17 ----

(In reply to comment #8)
> The original bug seems to have returned in latest HEAD. 
> Giving the code a serious going over with an eye to fixing the functionality
> and future maintainability
> 

Good idea.  One point for you to consider while you do this is that the admin pages for the MARC and authority frameworks do nearly exactly the same thing, just pointing to different database tables.  Refactoring so that the same routine or base class handles most of the work would make it possible to kill two birds with one stone.





--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:07 UTC  ---

This bug was previously known as _bug_ 3197 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3197
Imported an attachment (id=1160)

Unknown operating system Linux - Other. Setting to default OS "All".
Actual time not defined. Setting to 0.0
The original reporter of this bug does not have
   an account here. Reassigning to the person who moved
   it here: chris@bigballofwax.co.nz.
   Previous reporter was repke@xs4all.nl.
The original submitter of attachment 1160 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.

Comment 1 Chris Cormack 2010-12-15 01:11:58 UTC
Whats the status of this one?
Comment 2 Colin Campbell 2010-12-15 18:18:43 UTC
The problem does not persist in current HEAD. Lets close this for now