Bug 31987 - Update plugin unimarc_field_110.pl fields
Summary: Update plugin unimarc_field_110.pl fields
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Thibaud Guillot (thibaud_g)
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-26 12:28 UTC by Thibaud Guillot (thibaud_g)
Modified: 2023-06-08 22:28 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Circulation function:

Attachments
Bug 31987: Update plugin unimarc_field_110 fields (3.01 KB, patch)
2022-10-26 12:36 UTC, Thibaud Guillot (thibaud_g) 		Details | Diff | Splinter Review
Bug 31987: Update plugin unimarc_field_110 fields (3.06 KB, patch)
2022-10-27 09:21 UTC, David Nind 		Details | Diff | Splinter Review
Bug 31987: Update plugin unimarc_field_110 fields (3.11 KB, patch)
2022-11-02 19:21 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Bug 31987: (QA follow-up) Fix indentation and remove trailing spaces (41.78 KB, patch)
2022-11-02 19:21 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thibaud Guillot (thibaud_g) 2022-10-26 12:28:31 UTC 
Actually some fields are missing in plugin unimarc_field_110 it could be great to update it
Comment 1 Thibaud Guillot (thibaud_g) 2022-10-26 12:36:09 UTC 
Created attachment 142669 [details] [review]
Bug 31987: Update plugin unimarc_field_110 fields

According to https://www.ifla.org/wp-content/uploads/U_B_110_update2021_ONLINE_FINAL.pdf

Test plan:

1) Be sure to manage unimarc 110 field in your bibliographic framework
2) Edit a record and click on plugin unimarc_110_field input to see new
select values

Current status: NEW
Comment 2 David Nind 2022-10-27 09:21:31 UTC 
Created attachment 142698 [details] [review]
Bug 31987: Update plugin unimarc_field_110 fields

According to https://www.ifla.org/wp-content/uploads/U_B_110_update2021_ONLINE_FINAL.pdf

Test plan:

1) Be sure to manage unimarc 110 field in your bibliographic framework
2) Edit a record and click on plugin unimarc_110_field input to see new
select values

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2022-11-02 12:32:12 UTC 
Please don't forget to fill in the Assignee!
Comment 4 Katrin Fischer 2022-11-02 19:19:32 UTC 
Hi Thibaud, 

please make sure to run the QA tools on your patches and to set your editor to use 4 spaces for indentation instead of tabs:

 FAIL	koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_110.tt
   FAIL	  forbidden patterns
		forbidden pattern: tab char (line 37)
		forbidden pattern: tab char (line 38)
		forbidden pattern: tab char (line 39)
		forbidden pattern: tab char (line 40)
		forbidden pattern: tab char (line 42)
		forbidden pattern: tab char (line 43)
		forbidden pattern: tab char (line 44)
		forbidden pattern: tab char (line 45)
		forbidden pattern: tab char (line 47)
		forbidden pattern: tab char (line 48)
		forbidden pattern: tab char (line 49)
		forbidden pattern: tab char (line 50)
		forbidden pattern: tab char (line 52)
		forbidden pattern: tab char (line 53)
		forbidden pattern: tab char (line 54)
		forbidden pattern: tab char (line 55)
		forbidden pattern: tab char (line 57)
		forbidden pattern: tab char (line 58)
		forbidden pattern: tab char (line 59)
		forbidden pattern: tab char (line 60)
		forbidden pattern: tab char (line 62)
		forbidden pattern: tab char (line 63)
		forbidden pattern: tab char (line 64)
		forbidden pattern: tab char (line 65)
		forbidden pattern: tab char (line 67)
		forbidden pattern: tab char (line 68)
		forbidden pattern: tab char (line 69)
		forbidden pattern: tab char (line 70)
		forbidden pattern: tab char (line 72)
		forbidden pattern: tab char (line 73)
		forbidden pattern: tab char (line 74)
		forbidden pattern: tab char (line 75)
		forbidden pattern: tab char (line 77)
		forbidden pattern: tab char (line 78)
		forbidden pattern: tab char (line 79)
		forbidden pattern: tab char (line 80)
		forbidden pattern: tab char (line 184)
		forbidden pattern: tab char (line 185)
		forbidden pattern: tab char (line 186)
		forbidden pattern: tab char (line 187)

Will fix in a follow-up!
Comment 5 Katrin Fischer 2022-11-02 19:21:11 UTC 
Created attachment 143029 [details] [review]
Bug 31987: Update plugin unimarc_field_110 fields

According to https://www.ifla.org/wp-content/uploads/U_B_110_update2021_ONLINE_FINAL.pdf

Test plan:

1) Be sure to manage unimarc 110 field in your bibliographic framework
2) Edit a record and click on plugin unimarc_110_field input to see new
select values

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Katrin Fischer 2022-11-02 19:21:18 UTC 
Created attachment 143030 [details] [review]
Bug 31987: (QA follow-up) Fix indentation and remove trailing spaces

Fix tabs for 4 spaces in file.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Thibaud Guillot (thibaud_g) 2022-11-03 08:20:02 UTC 
(In reply to Katrin Fischer from comment #4)
> Hi Thibaud, 
> 
> please make sure to run the QA tools on your patches and to set your editor
> to use 4 spaces for indentation instead of tabs:
> 
>  FAIL
> koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/
> unimarc_field_110.tt
>    FAIL	  forbidden patterns
> 		forbidden pattern: tab char (line 37)
> 		forbidden pattern: tab char (line 38)
> 		forbidden pattern: tab char (line 39)
> 		forbidden pattern: tab char (line 40)
> 		forbidden pattern: tab char (line 42)
> 		forbidden pattern: tab char (line 43)
> 		forbidden pattern: tab char (line 44)
> 		forbidden pattern: tab char (line 45)
> 		forbidden pattern: tab char (line 47)
> 		forbidden pattern: tab char (line 48)
> 		forbidden pattern: tab char (line 49)
> 		forbidden pattern: tab char (line 50)
> 		forbidden pattern: tab char (line 52)
> 		forbidden pattern: tab char (line 53)
> 		forbidden pattern: tab char (line 54)
> 		forbidden pattern: tab char (line 55)
> 		forbidden pattern: tab char (line 57)
> 		forbidden pattern: tab char (line 58)
> 		forbidden pattern: tab char (line 59)
> 		forbidden pattern: tab char (line 60)
> 		forbidden pattern: tab char (line 62)
> 		forbidden pattern: tab char (line 63)
> 		forbidden pattern: tab char (line 64)
> 		forbidden pattern: tab char (line 65)
> 		forbidden pattern: tab char (line 67)
> 		forbidden pattern: tab char (line 68)
> 		forbidden pattern: tab char (line 69)
> 		forbidden pattern: tab char (line 70)
> 		forbidden pattern: tab char (line 72)
> 		forbidden pattern: tab char (line 73)
> 		forbidden pattern: tab char (line 74)
> 		forbidden pattern: tab char (line 75)
> 		forbidden pattern: tab char (line 77)
> 		forbidden pattern: tab char (line 78)
> 		forbidden pattern: tab char (line 79)
> 		forbidden pattern: tab char (line 80)
> 		forbidden pattern: tab char (line 184)
> 		forbidden pattern: tab char (line 185)
> 		forbidden pattern: tab char (line 186)
> 		forbidden pattern: tab char (line 187)
> 
> Will fix in a follow-up!

Oh sorry, it's my bad I forgot it... thanks to you and I will remember next time :)
Comment 8 Tomás Cohen Arazi (tcohen) 2022-11-04 22:14:40 UTC 
Pushed to master for 22.11.

Nice work everyone, thanks!