Bug 31996 - Make note-style messages consistent with dialogs
Summary: Make note-style messages consistent with dialogs
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 31973
Blocks:
  Show dependency treegraph
 
Reported: 2022-10-26 17:34 UTC by Owen Leonard
Modified: 2023-12-28 20:43 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31996: Make note-style messages consistent with dialogs (1.38 KB, patch)
2022-10-26 17:51 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31996: Make note-style messages consistent with dialogs (1.38 KB, patch)
2022-10-26 21:27 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31996: Make note-style messages consistent with dialogs (1.43 KB, patch)
2022-10-26 21:28 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2022-10-26 17:34:05 UTC
In a few places we use <div class="note"> which is an alternative to <div class="dialog message">, displaying at full width of the container and often prepended by an icon.

The style of this message has not been updated as part of the redesign. It should be made to match the .dialog.message style.
Comment 1 Owen Leonard 2022-10-26 17:51:26 UTC
Created attachment 142680 [details] [review]
Bug 31996: Make note-style messages consistent with dialogs

This patch modifies the style of divs with the class "note," making them
have the same background color as message dialogs as proposed in Bug
31973.

To test, apply the patch and rebuild the staff interface CSS.

Confirm that the updated style looks good. Some pages where you can find
examples:

- Administration -> Authorized values -> View a categories values.
- Administration -> Search engine cofiguration (with Elasticsearch
  enabled).
- Cataloging -> Batch record deletion -> Submit a list of biblionumbers.
Comment 2 Katrin Fischer 2022-10-26 21:25:50 UTC
Stlye guilde material? :)
Comment 3 Katrin Fischer 2022-10-26 21:27:24 UTC
Created attachment 142687 [details] [review]
Bug 31996: Make note-style messages consistent with dialogs

This patch modifies the style of divs with the class "note," making them
have the same background color as message dialogs as proposed in Bug
31973.

To test, apply the patch and rebuild the staff interface CSS.

Confirm that the updated style looks good. Some pages where you can find
examples:

- Administration -> Authorized values -> View a categories values.
- Administration -> Search engine cofiguration (with Elasticsearch
  enabled).
- Cataloging -> Batch record deletion -> Submit a list of biblionumbers.
Comment 4 Katrin Fischer 2022-10-26 21:28:16 UTC
Created attachment 142688 [details] [review]
Bug 31996: Make note-style messages consistent with dialogs

This patch modifies the style of divs with the class "note," making them
have the same background color as message dialogs as proposed in Bug
31973.

To test, apply the patch and rebuild the staff interface CSS.

Confirm that the updated style looks good. Some pages where you can find
examples:

- Administration -> Authorized values -> View a categories values.
- Administration -> Search engine cofiguration (with Elasticsearch
  enabled).
- Cataloging -> Batch record deletion -> Submit a list of biblionumbers.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2022-10-26 21:29:47 UTC
Simple CSS change, makes this fit in much better. Straight to PQA.
Comment 6 Tomás Cohen Arazi 2022-10-27 12:45:15 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!