Bug 32002 - Make submit button yellow on administration > Did you mean?
Summary: Make submit button yellow on administration > Did you mean?
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 31947
  Show dependency treegraph
 
Reported: 2022-10-26 20:10 UTC by Katrin Fischer
Modified: 2023-12-28 20:42 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 32002: Make submit button yellow on administration > Did you mean? (1.56 KB, patch)
2022-10-28 18:42 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32002: Make submit button yellow on administration > Did you mean? (1.61 KB, patch)
2022-10-28 20:02 UTC, David Nind
Details | Diff | Splinter Review
Bug 32002: Make submit button yellow on administration > Did you mean? (1.67 KB, patch)
2022-10-30 09:42 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-10-26 20:10:51 UTC

    
Comment 1 Owen Leonard 2022-10-28 18:42:07 UTC
Created attachment 142784 [details] [review]
Bug 32002: Make submit button yellow on administration > Did you mean?

This patch corrects the class on the "Did you mean?" page's save button
so that it is consistent with other primary submit buttons.

To test, apply the patch and go to Administration -> Did you mean?

The "Save configuration" button should be yellow.
Comment 2 David Nind 2022-10-28 20:02:16 UTC
Created attachment 142788 [details] [review]
Bug 32002: Make submit button yellow on administration > Did you mean?

This patch corrects the class on the "Did you mean?" page's save button
so that it is consistent with other primary submit buttons.

To test, apply the patch and go to Administration -> Did you mean?

The "Save configuration" button should be yellow.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2022-10-30 09:42:34 UTC
Created attachment 142809 [details] [review]
Bug 32002: Make submit button yellow on administration > Did you mean?

This patch corrects the class on the "Did you mean?" page's save button
so that it is consistent with other primary submit buttons.

To test, apply the patch and go to Administration -> Did you mean?

The "Save configuration" button should be yellow.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2022-11-03 12:05:50 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!