Bug 32014 - Tweak style of checkout settings panel
Summary: Tweak style of checkout settings panel
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 30952
Blocks:
  Show dependency treegraph
 
Reported: 2022-10-27 11:35 UTC by Owen Leonard
Modified: 2023-12-28 20:43 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 32014: Tweak style of checkout settings panel (2.06 KB, patch)
2022-10-27 11:50 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32014: Tweak style of checkout settings panel (2.11 KB, patch)
2022-10-28 18:54 UTC, David Nind
Details | Diff | Splinter Review
Bug 32014: Tweak style of checkout settings panel (2.16 KB, patch)
2022-10-30 09:36 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2022-10-27 11:35:33 UTC
I think the checkout settings panel layout is a little off, and could do more to highlight the information shown after checkout.
Comment 1 Owen Leonard 2022-10-27 11:50:32 UTC
Created attachment 142711 [details] [review]
Bug 32014: Tweak style of checkout settings panel

This patch makes some minor changes to the CSS controlling the way the
checkout settings panel displays, as well as the panel showing the last
checked-out item.

To test, apply the patch and rebuild the staff interface CSS.

- Go to Circulation and locate a patron to check out to.
- On the checkout page, click the "settings" icon in the barcode field.
- The checkout settings panel should display. Confirm that the spacing
  looks good.
- Check out an item to the patron.
- Confirm that the panel showing the last checked out item information
  looks correct: A green-bordered box with a white background, no
  rounded corners.
Comment 2 David Nind 2022-10-28 18:54:56 UTC
Created attachment 142785 [details] [review]
Bug 32014: Tweak style of checkout settings panel

This patch makes some minor changes to the CSS controlling the way the
checkout settings panel displays, as well as the panel showing the last
checked-out item.

To test, apply the patch and rebuild the staff interface CSS.

- Go to Circulation and locate a patron to check out to.
- On the checkout page, click the "settings" icon in the barcode field.
- The checkout settings panel should display. Confirm that the spacing
  looks good.
- Check out an item to the patron.
- Confirm that the panel showing the last checked out item information
  looks correct: A green-bordered box with a white background, no
  rounded corners.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2022-10-30 09:35:11 UTC
I am gald you caught this as the transparent look didn't work well for the 'just checked out'. Wondering if choosing a different background color might have made it stand out a little more, but I think we move into an area of personal tastes now (which is good :) )
Comment 4 Katrin Fischer 2022-10-30 09:36:05 UTC
Created attachment 142808 [details] [review]
Bug 32014: Tweak style of checkout settings panel

This patch makes some minor changes to the CSS controlling the way the
checkout settings panel displays, as well as the panel showing the last
checked-out item.

To test, apply the patch and rebuild the staff interface CSS.

- Go to Circulation and locate a patron to check out to.
- On the checkout page, click the "settings" icon in the barcode field.
- The checkout settings panel should display. Confirm that the spacing
  looks good.
- Check out an item to the patron.
- Confirm that the panel showing the last checked out item information
  looks correct: A green-bordered box with a white background, no
  rounded corners.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi 2022-11-02 22:28:03 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!