Bug 32041 - OPAC and staff interface results page do not honor SyndeticsCoverImageSize
Summary: OPAC and staff interface results page do not honor SyndeticsCoverImageSize
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Lucas Gass
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-29 21:19 UTC by Lucas Gass
Modified: 2023-12-28 20:43 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06,22.05.13


Attachments
Bug 32041: Enforce SyndeticsCoverImageSize everywhere (13.98 KB, patch)
2023-04-10 15:18 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 33168: (follow-up) Swap spaces for tabs (1.07 KB, patch)
2023-04-17 16:36 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 32041: Enforce SyndeticsCoverImageSize everywhere (14.06 KB, patch)
2023-04-23 21:52 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2022-10-29 21:19:17 UTC
The SyndeticsCoverImageSize system preference claims "Cover images from Syndetics on search results and item detail pages in the OPAC and the staff interface in a "medium/large" size.

Adjusting this system preference does not change the image size of the OPAC results page or staff client results page. 

Either the description of the system preference should be altered or the results pages should be made to honor the system preference.
Comment 1 Lucas Gass 2022-11-02 16:56:20 UTC
I think this is being handled correctly, the results pages should always show the smaller thumbnail type images. The system preference description should be updated.
Comment 2 Lucas Gass 2023-04-10 14:34:13 UTC
I've had many libraries complain about the small size/blurriness of cover images on the results page. We should make Syndetics cover images honor the 'SyndeticsCoverImageSize' in any place where they are displayed.
Comment 3 Lucas Gass 2023-04-10 15:18:13 UTC
Created attachment 149388 [details] [review]
Bug 32041: Enforce SyndeticsCoverImageSize everywhere

This patch add the SyndeticsCoverImageSize to the folling pages:

	koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
	koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc
	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt
	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt

To test:
1. Turn on SyndeticsCoverImages and SyndeticsEnabled.
2. Check the staff results page and make sure you can change the image size via SyndeticsCoverImageSize.
3. Check the OPAC results page.
4. Turn on 'OPACShelfBrowser' and make sure you change the image sizes within the shelf browser.
5. Test the OPAC checkout history page. ( opac-readingrecord.tt )
6. Have a checkout and an overdue to test the 2 tables on the OPAC summary pahe. ( opac-user.tt )
Comment 4 Barbara Johnson 2023-04-14 17:57:00 UTC
Everything about the patch worked great except for step #4.  Even though I had OPACShelfBrowser turned on I could never find any records in the OPAC that would display the shelf browser so I couldn't test that part.
Comment 5 Lucas Gass 2023-04-14 18:05:26 UTC
(In reply to Barbara Johnson from comment #4)
> Everything about the patch worked great except for step #4.  Even though I
> had OPACShelfBrowser turned on I could never find any records in the OPAC
> that would display the shelf browser so I couldn't test that part.

Did your items have an item.itemcallnumber?
Comment 6 Barbara Johnson 2023-04-14 18:08:31 UTC
They did not.  Let me add that and try again.
Comment 7 Barbara Johnson 2023-04-14 18:20:07 UTC
That worked.  The images do appear in the correct sizes in the shelf browser.  However, when scrolling back and forth through the titles in the shelf browser, once I go back to look at the original images they now display the ‘No cover image available’ graphic instead of the cover images.  It doesn’t seem to be holding on to the images.
Comment 8 Lucas Gass 2023-04-14 18:24:03 UTC
(In reply to Barbara Johnson from comment #7)
> That worked.  The images do appear in the correct sizes in the shelf
> browser.  However, when scrolling back and forth through the titles in the
> shelf browser, once I go back to look at the original images they now
> display the ‘No cover image available’ graphic instead of the cover images. 
> It doesn’t seem to be holding on to the images.

Is that behavior that you can recreate with or without this patch? If so, perhaps we should file a separate bug?
Comment 9 Barbara Johnson 2023-04-14 18:28:33 UTC
I’m not sure.  Is there a way to un-apply a patch on a sandbox?  Or do I need to start from scratch with a new one?
Comment 10 Katrin Fischer 2023-04-15 20:33:08 UTC
(In reply to Barbara Johnson from comment #9)
> I’m not sure.  Is there a way to un-apply a patch on a sandbox?  Or do I
> need to start from scratch with a new one?

You can't remove the patch, but you can make another sandbox without entering a bug number to get an installation without any chances for comparison.
Comment 11 ByWater Sandboxes 2023-04-17 16:36:22 UTC
Created attachment 149759 [details] [review]
Bug 33168: (follow-up) Swap spaces for tabs

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Comment 12 Barbara Johnson 2023-04-17 16:42:13 UTC
I retested and can confirm that the images not being retained when scrolling through the shelf browser exists without this patch.  It has already been filed as bug 29993.  Everything else about this patch works great.
Comment 13 Lucas Gass 2023-04-17 17:44:39 UTC
(In reply to Barbara Johnson from comment #12)
> I retested and can confirm that the images not being retained when scrolling
> through the shelf browser exists without this patch.  It has already been
> filed as bug 29993.  Everything else about this patch works great.

Thanks Barbara, I have also added a patch for Bug 29993.
Comment 14 Katrin Fischer 2023-04-23 21:50:34 UTC
Trusting Barbara and Lucas here for testing with Syndetics credentials. I have carefully reviewed the patch and compared it to how other syndetics file names were built previously and it all appears to match up.
Comment 15 Katrin Fischer 2023-04-23 21:52:15 UTC
Created attachment 150140 [details] [review]
Bug 32041: Enforce SyndeticsCoverImageSize everywhere

This patch add the SyndeticsCoverImageSize to the folling pages:

	koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
	koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc
	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt
	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
	koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt

To test:
1. Turn on SyndeticsCoverImages and SyndeticsEnabled.
2. Check the staff results page and make sure you can change the image size via SyndeticsCoverImageSize.
3. Check the OPAC results page.
4. Turn on 'OPACShelfBrowser' and make sure you change the image sizes within the shelf browser.
5. Test the OPAC checkout history page. ( opac-readingrecord.tt )
6. Have a checkout and an overdue to test the 2 tables on the OPAC summary pahe. ( opac-user.tt )

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 16 Tomás Cohen Arazi 2023-04-24 13:49:06 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 17 Jacob O'Mara 2023-05-10 15:00:37 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 18 Lucas Gass 2023-05-15 21:29:27 UTC
Backported to 22.05.x for upcoming 22.05.13
Comment 19 Arthur Suzuki 2023-05-23 14:44:27 UTC
doesn't apply on 21.11 please provide a backport if needed