Bug 32064 - Add missing test to template permission calculation
Summary: Add missing test to template permission calculation
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: David Cook
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 31389
Blocks:
  Show dependency treegraph
 
Reported: 2022-11-02 00:42 UTC by David Cook
Modified: 2023-12-28 20:42 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 32064: Add test data for all report subpermissions (1.61 KB, patch)
2022-11-02 00:46 UTC, David Cook
Details | Diff | Splinter Review
Bug 32064: Add test data for all report subpermissions (1.66 KB, patch)
2022-11-02 04:41 UTC, David Nind
Details | Diff | Splinter Review
Bug 32064: Add test data for all report subpermissions (1.72 KB, patch)
2022-11-02 13:18 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2022-11-02 00:42:03 UTC
Bug 31389 refactored how permissions are calculated for the templates. Today I realized there was 1 missing test to test that all subpermission authorizations are set when the top level permission is set.
Comment 1 David Cook 2022-11-02 00:46:04 UTC
Created attachment 142904 [details] [review]
Bug 32064: Add test data for all report subpermissions

This patch adds test data to prove that all authorizations
for subpermissions are set when only a top level flag is set.

To test:
0) Apply patch
1) prove ./t/Koha/Auth/Permissions.t
Comment 2 David Nind 2022-11-02 04:41:32 UTC
Created attachment 142913 [details] [review]
Bug 32064: Add test data for all report subpermissions

This patch adds test data to prove that all authorizations
for subpermissions are set when only a top level flag is set.

To test:
0) Apply patch
1) prove ./t/Koha/Auth/Permissions.t

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Cook 2022-11-02 05:29:19 UTC
Thanks, David :)
Comment 4 Katrin Fischer 2022-11-02 13:18:03 UTC
Created attachment 142976 [details] [review]
Bug 32064: Add test data for all report subpermissions

This patch adds test data to prove that all authorizations
for subpermissions are set when only a top level flag is set.

To test:
0) Apply patch
1) prove ./t/Koha/Auth/Permissions.t

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi 2022-11-03 12:56:17 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!