Bug 32068 - Consistent classes for primary buttons: Administration
Summary: Consistent classes for primary buttons: Administration
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on:
Blocks: 32067
  Show dependency treegraph
 
Reported: 2022-11-02 11:09 UTC by Owen Leonard
Modified: 2023-12-28 20:42 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Medium patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Circulation function:


Attachments
Bug 32068: Consistent classes for primary buttons: Administration (53.39 KB, patch)
2022-11-02 11:31 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32068: Consistent classes for primary buttons: Administration (53.45 KB, patch)
2022-11-02 12:59 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32068: Consistent classes for primary buttons: Administration (53.51 KB, patch)
2022-11-02 14:54 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2022-11-02 11:09:25 UTC
This patch will update buttons in the Administration area so that buttons which are currently styled as primary buttons will have the the "btn btn-primary" classes.

In some places, the classes have been added to buttons which were not input[type='submit'] but which should be styled as primary.
Comment 1 Owen Leonard 2022-11-02 11:31:07 UTC
Created attachment 142924 [details] [review]
Bug 32068: Consistent classes for primary buttons: Administration

This patch makes changes the button markup in Administration templates
so that all submit buttons and any buttons that should should be styled
as primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view pages in Administration to confirm
that everything looks correct. In most cases there are no visible
changes.
Comment 2 Katrin Fischer 2022-11-02 12:38:47 UTC
Looking here...
Comment 3 Katrin Fischer 2022-11-02 12:59:25 UTC
Created attachment 142953 [details] [review]
Bug 32068: Consistent classes for primary buttons: Administration

This patch makes changes the button markup in Administration templates
so that all submit buttons and any buttons that should should be styled
as primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view pages in Administration to confirm
that everything looks correct. In most cases there are no visible
changes.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Martin Renvoize (ashimema) 2022-11-02 14:54:12 UTC
Created attachment 142988 [details] [review]
Bug 32068: Consistent classes for primary buttons: Administration

This patch makes changes the button markup in Administration templates
so that all submit buttons and any buttons that should should be styled
as primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view pages in Administration to confirm
that everything looks correct. In most cases there are no visible
changes.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize (ashimema) 2022-11-02 14:54:47 UTC
This is great work, thanks Owen!

Passing QA
Comment 6 Tomás Cohen Arazi (tcohen) 2022-11-03 12:05:55 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!