Bug 32070 - Consistent classes for primary buttons: Acquisitions
Summary: Consistent classes for primary buttons: Acquisitions
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 32067
  Show dependency treegraph
 
Reported: 2022-11-02 11:43 UTC by Owen Leonard
Modified: 2023-12-28 20:42 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 32070: Consistent classes for primary buttons: Acquisitions (30.43 KB, patch)
2022-11-02 11:52 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32070: Consistent classes for primary buttons: Acquisitions (30.48 KB, patch)
2022-11-02 13:08 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32070: Consistent classes for primary buttons: Acquisitions (30.55 KB, patch)
2022-11-02 14:43 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2022-11-02 11:43:28 UTC
As part of Bug 32067 - [OMNIBUS] Consistent classes for submit and/or primary buttons:

This patch will update buttons in the Acquisitions area so that buttons which are currently styled as primary buttons will have the the "btn btn-primary" classes.

In some places, the classes have been added to buttons which were not input[type='submit'] but which should be styled as primary.
Comment 1 Owen Leonard 2022-11-02 11:52:31 UTC
Created attachment 142925 [details] [review]
Bug 32070: Consistent classes for primary buttons: Acquisitions

This patch makes changes the button markup in Acquisitions templates
so that all submit buttons and any buttons that should should be styled
as primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view pages in Acquisitions to confirm
that everything looks correct. In most cases there are no visible
changes.
Comment 2 Katrin Fischer 2022-11-02 13:05:49 UTC
Looking here...
Comment 3 Katrin Fischer 2022-11-02 13:08:38 UTC
Created attachment 142954 [details] [review]
Bug 32070: Consistent classes for primary buttons: Acquisitions

This patch makes changes the button markup in Acquisitions templates
so that all submit buttons and any buttons that should should be styled
as primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view pages in Acquisitions to confirm
that everything looks correct. In most cases there are no visible
changes.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Martin Renvoize 2022-11-02 14:43:51 UTC
Created attachment 142987 [details] [review]
Bug 32070: Consistent classes for primary buttons: Acquisitions

This patch makes changes the button markup in Acquisitions templates
so that all submit buttons and any buttons that should should be styled
as primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view pages in Acquisitions to confirm
that everything looks correct. In most cases there are no visible
changes.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize 2022-11-02 14:45:59 UTC
Passing QA as this just improves markup consistency..

What I'm less sure about is having all the actions buttons on the closed basketgroups table be primary.. it feels like primary should be saved for 'the main action on a page'.. can we really have a whole table full of 'main actions'?  One for the new style guide I reckon.
Comment 6 Owen Leonard 2022-11-02 15:13:41 UTC
I agree. I simply applied classes according to the existing markup, which consisted of input[type='submit'] which would have had the primary appearance regardless of the added class.
Comment 7 Tomás Cohen Arazi 2022-11-03 12:06:00 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!