Bug 32074 - Edit vendor has a floating toolbar, but still an additional save button at the bottom
Summary: Edit vendor has a floating toolbar, but still an additional save button at th...
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Matt Blenkinsop
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-02 13:04 UTC by Katrin Fischer
Modified: 2023-06-08 22:32 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.01


Attachments
Bug 32074: Edit vendor has two save buttons (1.72 KB, patch)
2022-12-02 11:05 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 32074: Edit vendor has two save buttons (1.76 KB, patch)
2022-12-02 12:21 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32074: Edit vendor has two save buttons (1.81 KB, patch)
2022-12-06 17:17 UTC, Lucas Gass
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-11-02 13:04:34 UTC
That's a small inconsistency with other forms having the floating toolbar. On the edit vendor form, there is also another save button at the bottom.
Comment 1 Matt Blenkinsop 2022-12-02 11:05:15 UTC
Created attachment 144395 [details] [review]
Bug 32074: Edit vendor has two save buttons

When editing a vendor there is a floating toolbar with options to save and cancel. There is also an additional save and cancel button set at the bottom of the page and this is superfluous. This has now been removed to leave the floating toolbar as the only toolbar.

Test plan:
1) Navigate to Acquisitions and select a Vendor.
2) Click edit vendor
3) Scroll down the page and observe that there is a floating save/cancel toolbar as well as the buttons to save/cancel at the bottom of the page
4) Apply patch
5) Observe that the duplicate buttons at the bottom of the page are now gone
Comment 2 Owen Leonard 2022-12-02 12:21:33 UTC
Created attachment 144396 [details] [review]
Bug 32074: Edit vendor has two save buttons

When editing a vendor there is a floating toolbar with options to save
and cancel. There is also an additional save and cancel button set at
the bottom of the page and this is superfluous. This has now been
removed to leave the floating toolbar as the only toolbar.

Test plan:
1) Navigate to Acquisitions and select a Vendor.
2) Click edit vendor
3) Scroll down the page and observe that there is a floating
   save/cancel toolbar as well as the buttons to save/cancel at the
   bottom of the page
4) Apply patch
5) Observe that the duplicate buttons at the bottom of the page are now
   gone

Signed-off-by: Owen <oleonard@myacpl.org>
Comment 3 Lucas Gass 2022-12-06 17:16:32 UTC
Straightforward template fix, QA script is happy. Thanks Matt!
Comment 4 Lucas Gass 2022-12-06 17:17:13 UTC
Created attachment 144454 [details] [review]
Bug 32074: Edit vendor has two save buttons

When editing a vendor there is a floating toolbar with options to save
and cancel. There is also an additional save and cancel button set at
the bottom of the page and this is superfluous. This has now been
removed to leave the floating toolbar as the only toolbar.

Test plan:
1) Navigate to Acquisitions and select a Vendor.
2) Click edit vendor
3) Scroll down the page and observe that there is a floating
   save/cancel toolbar as well as the buttons to save/cancel at the
   bottom of the page
4) Apply patch
5) Observe that the duplicate buttons at the bottom of the page are now
   gone

Signed-off-by: Owen <oleonard@myacpl.org>

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 5 Tomás Cohen Arazi 2022-12-07 14:39:32 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Jacob O'Mara 2022-12-08 11:11:24 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.