Bug 32076 - Form for editing a basket group is misaligned
Summary: Form for editing a basket group is misaligned
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Lucas Gass
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 30952
Blocks:
  Show dependency treegraph
 
Reported: 2022-11-02 14:45 UTC by Katrin Fischer
Modified: 2023-12-28 20:42 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 32076: Add page-section to basketgroup.tt and clean-up markup (17.26 KB, patch)
2022-11-02 19:01 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 32076: Add page-section to basketgroup.tt and clean-up markup (17.30 KB, patch)
2022-11-03 01:53 UTC, David Nind
Details | Diff | Splinter Review
Bug 32076: Add page-section to basketgroup.tt and clean-up markup (17.36 KB, patch)
2022-11-03 09:36 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-11-02 14:45:23 UTC
The input fields on the edit form for basket groups are misaligned and the 'ungrouped baskets' on the right should probably be page-sectioned.
Comment 1 Lucas Gass 2022-11-02 19:01:07 UTC
Created attachment 143026 [details] [review]
Bug 32076: Add page-section to basketgroup.tt and clean-up markup

This patch adds the page-section div to the basket group 'Ungrouped baskets'. It also adds the row class to the fieldset to get the list to display properly.

To test:
1. Apply patch
2. Make sure the page section div for 'Ungrouped baskets' looks good.
3. Look at the markup changes and make sure the make sense.
4. Make sure the form still works as it should.
Comment 2 David Nind 2022-11-03 01:53:58 UTC
Created attachment 143055 [details] [review]
Bug 32076: Add page-section to basketgroup.tt and clean-up markup

This patch adds the page-section div to the basket group 'Ungrouped baskets'. It also adds the row class to the fieldset to get the list to display properly.

To test:
1. Apply patch
2. Make sure the page section div for 'Ungrouped baskets' looks good.
3. Look at the markup changes and make sure the make sense.
4. Make sure the form still works as it should.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2022-11-03 09:36:35 UTC
Created attachment 143068 [details] [review]
Bug 32076: Add page-section to basketgroup.tt and clean-up markup

This patch adds the page-section div to the basket group 'Ungrouped baskets'. It also adds the row class to the fieldset to get the list to display properly.

To test:
1. Apply patch
2. Make sure the page section div for 'Ungrouped baskets' looks good.
3. Look at the markup changes and make sure the make sense.
4. Make sure the form still works as it should.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Katrin Fischer 2022-11-03 09:39:59 UTC
Nice fix, thx Lucas. Could you maybe take a look at bug 31819?
Comment 5 Tomás Cohen Arazi 2022-11-03 14:32:29 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!