The input fields on the edit form for basket groups are misaligned and the 'ungrouped baskets' on the right should probably be page-sectioned.
Created attachment 143026 [details] [review] Bug 32076: Add page-section to basketgroup.tt and clean-up markup This patch adds the page-section div to the basket group 'Ungrouped baskets'. It also adds the row class to the fieldset to get the list to display properly. To test: 1. Apply patch 2. Make sure the page section div for 'Ungrouped baskets' looks good. 3. Look at the markup changes and make sure the make sense. 4. Make sure the form still works as it should.
Created attachment 143055 [details] [review] Bug 32076: Add page-section to basketgroup.tt and clean-up markup This patch adds the page-section div to the basket group 'Ungrouped baskets'. It also adds the row class to the fieldset to get the list to display properly. To test: 1. Apply patch 2. Make sure the page section div for 'Ungrouped baskets' looks good. 3. Look at the markup changes and make sure the make sense. 4. Make sure the form still works as it should. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 143068 [details] [review] Bug 32076: Add page-section to basketgroup.tt and clean-up markup This patch adds the page-section div to the basket group 'Ungrouped baskets'. It also adds the row class to the fieldset to get the list to display properly. To test: 1. Apply patch 2. Make sure the page section div for 'Ungrouped baskets' looks good. 3. Look at the markup changes and make sure the make sense. 4. Make sure the form still works as it should. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice fix, thx Lucas. Could you maybe take a look at bug 31819?
Pushed to master for 22.11. Nice work everyone, thanks!