Bug 32101 - Add padding to floating toolbars
Summary: Add padding to floating toolbars
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 30952
Blocks:
  Show dependency treegraph
 
Reported: 2022-11-03 17:44 UTC by Owen Leonard
Modified: 2023-06-08 22:28 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Patron entry form floating toolbar (23.61 KB, image/png)
2022-11-03 17:44 UTC, Owen Leonard
Details
Bug 32101: Add padding to floating toolbars (1.39 KB, patch)
2022-11-03 17:51 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32101: Add padding to floating toolbars (1.45 KB, patch)
2022-11-03 19:20 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 32101: Add padding to floating toolbars (1.50 KB, patch)
2022-11-10 00:36 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2022-11-03 17:44:06 UTC
Created attachment 143145 [details]
Patron entry form floating toolbar

In several cases floating toolbars have no padding, making the layout seem awkward. See attached screenshot.
Comment 1 Owen Leonard 2022-11-03 17:51:00 UTC
Created attachment 143147 [details] [review]
Bug 32101: Add padding to floating toolbars

This patch makes a slight change to the CSS controling the appearance of
floating toolbars. In some cases the lack of padding around the toolbar
elements made it look awkward.

To test, apply the patch and rebuild the staff interface CSS.

View various pages to confirm that the toolbar looks correct when you
scroll down and the toolbar "sticks" to the top of the browser viewport.
For example:

- Patrons -> Search results
- Patrons -> Add/edit patron
- Catalog -> Advanced search form
- Administration -> Preferences
- Authorities -> Add/edit authority
- Cataloging -> Add/edit MARC record
- Catalog -> Item search form
Comment 2 Lucas Gass 2022-11-03 19:20:46 UTC
Created attachment 143150 [details] [review]
Bug 32101: Add padding to floating toolbars

This patch makes a slight change to the CSS controling the appearance of
floating toolbars. In some cases the lack of padding around the toolbar
elements made it look awkward.

To test, apply the patch and rebuild the staff interface CSS.

View various pages to confirm that the toolbar looks correct when you
scroll down and the toolbar "sticks" to the top of the browser viewport.
For example:

- Patrons -> Search results
- Patrons -> Add/edit patron
- Catalog -> Advanced search form
- Administration -> Preferences
- Authorities -> Add/edit authority
- Cataloging -> Add/edit MARC record
- Catalog -> Item search form

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Lucas Gass 2022-11-03 19:21:18 UTC
Thanks Owen, I've noticed this but neglected to file a bug. Glad to see it fixed.
Comment 4 Jonathan Druart 2022-11-04 09:19:42 UTC
*** Bug 31944 has been marked as a duplicate of this bug. ***
Comment 5 Jonathan Druart 2022-11-04 09:22:00 UTC
Better but still misaligned IMO.

https://snipboard.io/XE7LgI.jpg
Comment 6 Katrin Fischer 2022-11-10 00:36:56 UTC
Created attachment 143609 [details] [review]
Bug 32101: Add padding to floating toolbars

This patch makes a slight change to the CSS controling the appearance of
floating toolbars. In some cases the lack of padding around the toolbar
elements made it look awkward.

To test, apply the patch and rebuild the staff interface CSS.

View various pages to confirm that the toolbar looks correct when you
scroll down and the toolbar "sticks" to the top of the browser viewport.
For example:

- Patrons -> Search results
- Patrons -> Add/edit patron
- Catalog -> Advanced search form
- Administration -> Preferences
- Authorities -> Add/edit authority
- Cataloging -> Add/edit MARC record
- Catalog -> Item search form

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Tomás Cohen Arazi 2022-11-10 13:06:45 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!