Bug 32114 - Template error in OPAC search results RSS
Summary: Template error in OPAC search results RSS
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low major
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 28307
  Show dependency tree / graph
 
Reported: 2022-11-05 15:57 UTC by Owen Leonard
Modified: 2023-12-28 20:44 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.08
Circulation function:

Attachments
Bug 32114: Add missing html_helpers.inc (1.37 KB, patch)
2022-11-05 16:05 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 32114: Add missing html_helpers.inc (1.42 KB, patch)
2022-11-05 17:53 UTC, David Nind 		Details | Diff | Splinter Review
Bug 32114: Add missing html_helpers.inc (1.48 KB, patch)
2022-11-09 12:16 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2022-11-05 15:57:12 UTC 
Found during testing of Bug 28307:

> But I get the following error when
> clicking on the RSS feed for a search results page: 
> Template process failed: file error - biblio_a_href: not found at
> /kohadevbox/koha/C4/Templates.pm line 127
Comment 1 Owen Leonard 2022-11-05 16:05:40 UTC 
Created attachment 143297 [details] [review]
Bug 32114: Add missing html_helpers.inc

This patch makes a minor modification to the OPAC
search results RSS template so that an error isn't
triggered. The html_helpers include was missing.

To test, apply the patch and perform a catalog
search in the OPAC which will return results.

At the end of the "Your search results" heading
you should see an orange RSS icon. Clicking on it
should take you to an RSS feed instead of an
error page.
Comment 2 David Nind 2022-11-05 17:53:38 UTC 
Created attachment 143298 [details] [review]
Bug 32114: Add missing html_helpers.inc

This patch makes a minor modification to the OPAC
search results RSS template so that an error isn't
triggered. The html_helpers include was missing.

To test, apply the patch and perform a catalog
search in the OPAC which will return results.

At the end of the "Your search results" heading
you should see an orange RSS icon. Clicking on it
should take you to an RSS feed instead of an
error page.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2022-11-09 12:16:31 UTC 
Created attachment 143495 [details] [review]
Bug 32114: Add missing html_helpers.inc

This patch makes a minor modification to the OPAC
search results RSS template so that an error isn't
triggered. The html_helpers include was missing.

To test, apply the patch and perform a catalog
search in the OPAC which will return results.

At the end of the "Your search results" heading
you should see an orange RSS icon. Clicking on it
should take you to an RSS feed instead of an
error page.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi (tcohen) 2022-11-09 13:07:27 UTC 
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 5 Lucas Gass (lukeg) 2022-12-21 16:55:03 UTC 
Backported to 22.05.x for upcoming 22.05.08
Comment 6 Marcel de Rooy 2023-01-11 13:11:31 UTC 
This has been backported to 21.11.x too. But it is actually not needed there. It does not use BLOCK biblio_a_href.
Comment 7 Wainui Witika-Park 2023-03-15 01:19:59 UTC 
Not backported to 21.05.x