Bug 32119 - Cannot add new guarantee
Summary: Cannot add new guarantee
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low critical (vote)
Assignee: Nick Clemens
QA Contact: Testopia
URL:
Keywords:
Depends on: 31422
Blocks:
  Show dependency treegraph
 
Reported: 2022-11-07 12:10 UTC by Jonathan Druart
Modified: 2023-06-08 22:28 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 32119: (bug 31422 follow-up) Fix add guarantee (1.27 KB, patch)
2022-11-07 12:12 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32119: (bug 31422 follow-up) Fix add guarantee (1.31 KB, patch)
2022-11-07 12:20 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32119: (bug 31422 follow-up) Fix add guarantee (1.21 KB, patch)
2022-11-07 12:44 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 32119: (bug 31422 follow-up) Fix add guarantee (1.28 KB, patch)
2022-11-07 12:50 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32119: (bug 31422 follow-up) Fix add guarantee (1.34 KB, patch)
2022-11-07 14:13 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2022-11-07 12:10:29 UTC
Can't call method "id" on an undefined value at /kohadevbox/koha/members/memberentry.pl line 662                                                                                                                             eval {...} at /kohadevbox/koha/members/memberentry.pl line 932

To recreate:
go to a patron detail view, click "add guarantee"
Comment 1 Jonathan Druart 2022-11-07 12:12:35 UTC
Created attachment 143351 [details] [review]
Bug 32119: (bug 31422 follow-up) Fix add guarantee

Can't call method "id" on an undefined value at /kohadevbox/koha/members/memberentry.pl line 662                                                                                                                             eval {...} at /kohadevbox/koha/members/memberentry.pl line 932

To recreate:
go to a patron detail view, click "add guarantee"
Comment 2 Owen Leonard 2022-11-07 12:20:28 UTC
Created attachment 143352 [details] [review]
Bug 32119: (bug 31422 follow-up) Fix add guarantee

Can't call method "id" on an undefined value at /kohadevbox/koha/members/memberentry.pl line 662                                                                                                                             eval {...} at /kohadevbox/koha/members/memberentry.pl line 932

To recreate:
go to a patron detail view, click "add guarantee"

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Nick Clemens 2022-11-07 12:44:04 UTC
Created attachment 143364 [details] [review]
Bug 32119: (bug 31422 follow-up) Fix add guarantee

To test:
1 - go to a patron detail view, click "add guarantee"
2 - Confirm form loads
3 - Confirm categories lsited are eligible to have a guarantor
4 - Fill out required fields and confirm patron saved correctly
Comment 4 Jonathan Druart 2022-11-07 12:50:45 UTC
Created attachment 143366 [details] [review]
Bug 32119: (bug 31422 follow-up) Fix add guarantee

To test:
1 - go to a patron detail view, click "add guarantee"
2 - Confirm form loads
3 - Confirm categories lsited are eligible to have a guarantor
4 - Fill out required fields and confirm patron saved correctly

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Tomás Cohen Arazi 2022-11-07 14:13:10 UTC
Created attachment 143371 [details] [review]
Bug 32119: (bug 31422 follow-up) Fix add guarantee

To test:
1 - go to a patron detail view, click "add guarantee"
2 - Confirm form loads
3 - Confirm categories lsited are eligible to have a guarantor
4 - Fill out required fields and confirm patron saved correctly

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 6 Tomás Cohen Arazi 2022-11-07 14:20:53 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!