Bug 32122 - Wrong permissions check on item circulation alerts
Summary: Wrong permissions check on item circulation alerts
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Nick Clemens (kidclamp)
QA Contact: Testopia
URL:
Keywords:
Depends on: 14391
Blocks:
  Show dependency tree / graph
 
Reported: 2022-11-07 13:56 UTC by Nick Clemens (kidclamp)
Modified: 2023-06-08 22:28 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Circulation function:

Attachments
Bug 32122: Correct permissions check on item circulation alerts (1.29 KB, patch)
2022-11-07 13:58 UTC, Nick Clemens (kidclamp) 		Details | Diff | Splinter Review
Bug 32122: Correct permissions check on item circulation alerts (1.35 KB, patch)
2022-11-07 14:18 UTC, Tomás Cohen Arazi (tcohen) 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2022-11-07 13:56:08 UTC 
Bug 14391 added granular permissions for the administration module, however, there was a mismatch in the check on item circulation alerts and the new permission
Comment 1 Nick Clemens (kidclamp) 2022-11-07 13:58:44 UTC 
Created attachment 143370 [details] [review]
Bug 32122: Correct permissions check on item circulation alerts

This patch changes the check from 'item_circ_alerts' to 'manage_item_circ_alerts'

To test:
1 - Give an account catalogue and manage_item_circ_alerts permissions
2 - Log in to staff client iwht this account
3 - Browse to Admin->Item circulation alerts
4 - Error, you do not have permission to view this page
5 - Apply patch
6 - Restart all
7 - Browse to page agian, success!
Comment 2 Nick Clemens (kidclamp) 2022-11-07 14:08:49 UTC 
Straight to QA, minor and easy fix
Comment 3 Tomás Cohen Arazi (tcohen) 2022-11-07 14:18:39 UTC 
Created attachment 143372 [details] [review]
Bug 32122: Correct permissions check on item circulation alerts

This patch changes the check from 'item_circ_alerts' to 'manage_item_circ_alerts'

To test:
1 - Give an account catalogue and manage_item_circ_alerts permissions
2 - Log in to staff client iwht this account
3 - Browse to Admin->Item circulation alerts
4 - Error, you do not have permission to view this page
5 - Apply patch
6 - Restart all
7 - Browse to page agian, success!

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 4 Tomás Cohen Arazi (tcohen) 2022-11-07 14:21:00 UTC 
Pushed to master for 22.11.

Nice work everyone, thanks!