Bug 32139 - "Update on login" setting not set when creating domain from new IdP page
Summary: "Update on login" setting not set when creating domain from new IdP page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Authentication (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: David Cook
QA Contact: Testopia
URL:
Keywords:
Depends on: 31378
Blocks:
  Show dependency treegraph
 
Reported: 2022-11-08 23:59 UTC by David Cook
Modified: 2023-06-08 22:28 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 32139: Set "update on login" correctly when creating new IdP (1.62 KB, patch)
2022-11-09 02:03 UTC, David Cook
Details | Diff | Splinter Review
Bug 32139: Set "update on login" correctly when creating new IdP (1.68 KB, patch)
2022-11-09 16:33 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2022-11-08 23:59:38 UTC
When you're creating a new Identity Provider, you're prompted to create a domain. 

All the settings are saved correctly except "Update on login". It will be set to "No" even when you select "Yes"
Comment 1 David Cook 2022-11-09 02:03:41 UTC
Created attachment 143454 [details] [review]
Bug 32139: Set "update on login" correctly when creating new IdP

This patches allows "Update on Login" to be set to "Yes" when
creating a domain as part of a new Identity Provider.

Test plan:
1) Apply patch
2) koha-plack --reload kohadev
3) Go to http://localhost:8081/cgi-bin/koha/admin/identity_providers.pl
4) Click "New identity provider"
5) Fill in "Code" and "Description" with "test"
6) Click "Add default OAuth configuration"
7) Click "Add default OAUth mapping"
8) Fill in "Domain" with "*"
9) Change "Allow OPAC", "Allow staff", "Auto register", and "Update on login"
to "Yes"
10) Click "Submit"
11) Click "Manage Domains" for your new Identity Provider
12) Note that "Allow opac", "Allow staff", "Auto register", and "Update on login"
are all set to "Yes"
Comment 2 Tomás Cohen Arazi 2022-11-09 16:33:40 UTC
Created attachment 143523 [details] [review]
Bug 32139: Set "update on login" correctly when creating new IdP

This patches allows "Update on Login" to be set to "Yes" when
creating a domain as part of a new Identity Provider.

Test plan:
1) Apply patch
2) koha-plack --reload kohadev
3) Go to http://localhost:8081/cgi-bin/koha/admin/identity_providers.pl
4) Click "New identity provider"
5) Fill in "Code" and "Description" with "test"
6) Click "Add default OAuth configuration"
7) Click "Add default OAUth mapping"
8) Fill in "Domain" with "*"
9) Change "Allow OPAC", "Allow staff", "Auto register", and "Update on login"
to "Yes"
10) Click "Submit"
11) Click "Manage Domains" for your new Identity Provider
12) Note that "Allow opac", "Allow staff", "Auto register", and "Update on login"
are all set to "Yes"

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 3 Tomás Cohen Arazi 2022-11-09 17:40:29 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!