Bug 32148 - Buttons must inherit Bootstrap size classes
Summary: Buttons must inherit Bootstrap size classes
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 32044
Blocks: 32071
  Show dependency treegraph
 
Reported: 2022-11-09 14:07 UTC by Owen Leonard
Modified: 2023-06-08 22:28 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 32148: Buttons must inherit Bootstrap size classes (2.78 KB, patch)
2022-11-09 14:20 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32148: Buttons must inherit Bootstrap size classes (2.78 KB, patch)
2022-11-09 21:49 UTC, David Nind
Details | Diff | Splinter Review
Bug 32148: Buttons must inherit Bootstrap size classes (2.89 KB, patch)
2022-11-09 23:51 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2022-11-09 14:07:53 UTC
The global changes to button styles made by Bug 32044 created an issue with button styling: The default font size and padding changes have the side-effect of overriding Bootstrap's button size classes: btn-sm, btn-xs, etc.
Comment 1 Owen Leonard 2022-11-09 14:20:42 UTC
Created attachment 143517 [details] [review]
Bug 32148: Buttons must inherit Bootstrap size classes

This patch removes global font and padding settings which were
overriding the Bootstrap classes we use to change the size of Bootstrap
buttons. The font and padding settings are moved to the CSS which covers
button which are not styled as Bootstrap buttons.

To test, apply the patch and view pages where buttons are styled with
different Bootstrap size classes:

- Circulation -> Check out:
  - The "Check out" button, the "Show checkouts" button, Renew buttons
    in the footer.
- Patrons -> Patron details -> Edit buttons in each section.
- Patrons home -> Buttons in sidebar filter
- Catalog -> Bibliographic details -> Item details
Comment 2 David Nind 2022-11-09 21:49:30 UTC
Created attachment 143596 [details] [review]
Bug 32148: Buttons must inherit Bootstrap size classes

This patch removes global font and padding settings which were
overriding the Bootstrap classes we use to change the size of Bootstrap
buttons. The font and padding settings are moved to the CSS which covers
button which are not styled as Bootstrap buttons.

To test, apply the patch and view pages where buttons are styled with
different Bootstrap size classes:

- Circulation -> Check out:
  - The "Check out" button, the "Show checkouts" button, Renew buttons
    in the footer.
- Patrons -> Patron details -> Edit buttons in each section.
- Patrons home -> Buttons in sidebar filter
- Catalog -> Bibliographic details -> Item details
Comment 3 Katrin Fischer 2022-11-09 23:51:40 UTC
Created attachment 143607 [details] [review]
Bug 32148: Buttons must inherit Bootstrap size classes

This patch removes global font and padding settings which were
overriding the Bootstrap classes we use to change the size of Bootstrap
buttons. The font and padding settings are moved to the CSS which covers
button which are not styled as Bootstrap buttons.

To test, apply the patch and view pages where buttons are styled with
different Bootstrap size classes:

- Circulation -> Check out:
  - The "Check out" button, the "Show checkouts" button, Renew buttons
    in the footer.
- Patrons -> Patron details -> Edit buttons in each section.
- Patrons home -> Buttons in sidebar filter
- Catalog -> Bibliographic details -> Item details

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2022-11-10 13:06:57 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!