Bug 32151 - [WARN] Use of uninitialized value in numeric ne (!=) at C4/Ris.pm line 834.
Summary: [WARN] Use of uninitialized value in numeric ne (!=) at C4/Ris.pm line 834.
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Marcel de Rooy
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-09 15:11 UTC by Marcel de Rooy
Modified: 2023-06-08 22:28 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 32151: Resolve uninitialized warn in numeric ne in C4::Ris (1.06 KB, patch)
2022-11-09 15:16 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 32151: Resolve uninitialized warn in numeric ne in C4::Ris (1.10 KB, patch)
2022-11-11 14:20 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2022-11-09 15:11:26 UTC
Line 834 (21.11) shows the ugly:
    if ($kwfield != undef) {

Master same line.
Comment 1 Marcel de Rooy 2022-11-09 15:16:31 UTC
Created attachment 143519 [details] [review]
Bug 32151: Resolve uninitialized warn in numeric ne in C4::Ris

We should not write:
    if ($kwfield != undef) {

Test plan:
Pick record with UTF8 chars.
Download via cart or shelf in RIS format.
Check your logs.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2022-11-09 15:17:23 UTC
Trivial oneliner. Self SO
Comment 3 Jonathan Druart 2022-11-11 14:20:56 UTC
Created attachment 143790 [details] [review]
Bug 32151: Resolve uninitialized warn in numeric ne in C4::Ris

We should not write:
    if ($kwfield != undef) {

Test plan:
Pick record with UTF8 chars.
Download via cart or shelf in RIS format.
Check your logs.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Tomás Cohen Arazi 2022-11-11 17:33:18 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!