Bug 32159 - Uncertain prices has 2 level 1 headings
Summary: Uncertain prices has 2 level 1 headings
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Katrin Fischer
QA Contact: Kyle M Hall
URL:
Keywords: Academy, accessibility
Depends on:
Blocks:
 
Reported: 2022-11-09 23:18 UTC by Katrin Fischer
Modified: 2023-12-28 20:44 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04


Attachments
Bug 32159: Fix heading hierarchy on uncertain prices page (1.98 KB, patch)
2023-02-09 21:55 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32159: Fix heading hierarchy on uncertain prices page (2.04 KB, patch)
2023-02-14 21:44 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32159: Fix heading hierarchy on uncertain prices page (2.09 KB, patch)
2023-02-17 19:02 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 32159: Fix heading hierarchy on uncertain prices page (2.16 KB, patch)
2023-02-23 09:43 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-11-09 23:18:18 UTC
Instead of h1 - h2 - h2 we have 2 h1 headings with almost the same text on the uncertain prices page in acquisitions.
Comment 1 Katrin Fischer 2023-02-09 21:55:45 UTC
Created attachment 146455 [details] [review]
Bug 32159: Fix heading hierarchy on uncertain prices page

This makes sure we don't have 2 level 1 headings on the same page.

To test:
* Create a new order for a basket in the acq module,
  make sure the uncertain price checkbox is checked bevor saving
* Go to uncertain prices using the link in the toolbar on the
  basket summary page
* Verify that there are 2 almost identical h1 headings and a "/ Fax:"
  reference at the top of the page
* Apply patch
* Verify that we now have one level 1 heading and a level 2 heading
  for each section. The fax reference is also gone.
Comment 2 Owen Leonard 2023-02-14 21:44:12 UTC
Created attachment 146646 [details] [review]
Bug 32159: Fix heading hierarchy on uncertain prices page

This makes sure we don't have 2 level 1 headings on the same page.

To test:
* Create a new order for a basket in the acq module,
  make sure the uncertain price checkbox is checked bevor saving
* Go to uncertain prices using the link in the toolbar on the
  basket summary page
* Verify that there are 2 almost identical h1 headings and a "/ Fax:"
  reference at the top of the page
* Apply patch
* Verify that we now have one level 1 heading and a level 2 heading
  for each section. The fax reference is also gone.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Kyle M Hall 2023-02-17 19:02:47 UTC
Created attachment 146907 [details] [review]
Bug 32159: Fix heading hierarchy on uncertain prices page

This makes sure we don't have 2 level 1 headings on the same page.

To test:
* Create a new order for a basket in the acq module,
  make sure the uncertain price checkbox is checked bevor saving
* Go to uncertain prices using the link in the toolbar on the
  basket summary page
* Verify that there are 2 almost identical h1 headings and a "/ Fax:"
  reference at the top of the page
* Apply patch
* Verify that we now have one level 1 heading and a level 2 heading
  for each section. The fax reference is also gone.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Jonathan Druart 2023-02-23 09:43:29 UTC
Created attachment 147207 [details] [review]
Bug 32159: Fix heading hierarchy on uncertain prices page

This makes sure we don't have 2 level 1 headings on the same page.

To test:
* Create a new order for a basket in the acq module,
  make sure the uncertain price checkbox is checked bevor saving
* Go to uncertain prices using the link in the toolbar on the
  basket summary page
* Verify that there are 2 almost identical h1 headings and a "/ Fax:"
  reference at the top of the page
* Apply patch
* Verify that we now have one level 1 heading and a level 2 heading
  for each section. The fax reference is also gone.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Tomás Cohen Arazi 2023-02-27 16:07:05 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Matt Blenkinsop 2023-03-01 09:53:59 UTC
Nice work everyone!

Pushed to stable for 22.11.x