Bug 32164 - Add link to MARC modification templates from batch record modification page
Summary: Add link to MARC modification templates from batch record modification page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Kyle M Hall
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-10 09:16 UTC by Katrin Fischer
Modified: 2023-12-28 20:43 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00


Attachments
Bug 32164: Add link to MARC modification templates from batch record modification page (3.50 KB, patch)
2023-02-13 19:48 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32164: Add link to MARC modification templates from batch record modification page (6.70 KB, patch)
2023-02-14 15:15 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32164: Add link to MARC modification templates from batch record modification page (6.76 KB, patch)
2023-02-20 22:00 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32164: Add link to MARC modification templates from batch record modification page (6.82 KB, patch)
2023-03-24 10:56 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-11-10 09:16:48 UTC
When no MARC modification templates are defined and you open up the page for the batch record modification, we show a hint:

/cgi-bin/koha/tools/batch_record_modification.pl

No MARC modification template is defined. You have to create at least one template for using this tool. 

It would be nice if we linked to the MARC modification tools there directly.
Comment 1 Owen Leonard 2023-02-13 19:48:28 UTC
Created attachment 146600 [details] [review]
Bug 32164: Add link to MARC modification templates from batch record modification page

This patch adds a more visible link from the batch record modification
page in the event that there are no MARC modification templates defined.

The patch also modifies the same message on the MARC modification
templates page so that the interfaces are more unified.

To test you should have no MARC modification templates defined.

- Apply the patch and go to Tools -> Batch record modification.
- You should see a message dialog containing a button, "Create a new
  MARC modification template."
- Clicking it should take you to the MARC modification templates page,
  where you'll see a similar message and a button, "Create a new
  template." Clicking this button should trigger a modal form, just like
  clicking the "New template" button in the toolbar should.
Comment 2 Owen Leonard 2023-02-14 15:15:48 UTC
Created attachment 146640 [details] [review]
Bug 32164: Add link to MARC modification templates from batch record modification page

This patch adds a more visible link from the batch record modification
page in the event that there are no MARC modification templates defined.
The template checks that the user has permission.

The patch also modifies the same message on the MARC modification
templates page so that the interfaces are more unified, and tweaks the
operation of the "New action" button.

To test you should have no MARC modification templates defined.

- Apply the patch and go to Tools -> Batch record modification.
- If you're logged in as a user with permission you should see a message
  dialog containing a button, "Create a new MARC modification template."
- Clicking it should take you to the MARC modification templates page,
  where you'll see a similar message and a button, "Create a new
  template." Clicking this button should trigger a modal form, just like
  clicking the "New template" button in the toolbar should.
- Submit the form to create a new template. You should see message on
  the following page that says "New action." Clicking the button should
  display the entry form, and then clicking "Cancel" should hide the
  form and redisplay the message.
Comment 3 Katrin Fischer 2023-02-20 22:00:57 UTC
Created attachment 146979 [details] [review]
Bug 32164: Add link to MARC modification templates from batch record modification page

This patch adds a more visible link from the batch record modification
page in the event that there are no MARC modification templates defined.
The template checks that the user has permission.

The patch also modifies the same message on the MARC modification
templates page so that the interfaces are more unified, and tweaks the
operation of the "New action" button.

To test you should have no MARC modification templates defined.

- Apply the patch and go to Tools -> Batch record modification.
- If you're logged in as a user with permission you should see a message
  dialog containing a button, "Create a new MARC modification template."
- Clicking it should take you to the MARC modification templates page,
  where you'll see a similar message and a button, "Create a new
  template." Clicking this button should trigger a modal form, just like
  clicking the "New template" button in the toolbar should.
- Submit the form to create a new template. You should see message on
  the following page that says "New action." Clicking the button should
  display the entry form, and then clicking "Cancel" should hide the
  form and redisplay the message.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>



Current patch-complexity: Small patch
Comment 4 Kyle M Hall 2023-03-24 10:56:33 UTC
Created attachment 148653 [details] [review]
Bug 32164: Add link to MARC modification templates from batch record modification page

This patch adds a more visible link from the batch record modification
page in the event that there are no MARC modification templates defined.
The template checks that the user has permission.

The patch also modifies the same message on the MARC modification
templates page so that the interfaces are more unified, and tweaks the
operation of the "New action" button.

To test you should have no MARC modification templates defined.

- Apply the patch and go to Tools -> Batch record modification.
- If you're logged in as a user with permission you should see a message
  dialog containing a button, "Create a new MARC modification template."
- Clicking it should take you to the MARC modification templates page,
  where you'll see a similar message and a button, "Create a new
  template." Clicking this button should trigger a modal form, just like
  clicking the "New template" button in the toolbar should.
- Submit the form to create a new template. You should see message on
  the following page that says "New action." Clicking the button should
  display the entry form, and then clicking "Cancel" should hide the
  form and redisplay the message.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 5 Tomás Cohen Arazi 2023-04-06 12:52:27 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Jacob O'Mara 2023-04-17 07:19:51 UTC
Enhancement - not backporting to 22.11.x

Nice work everyone!
Comment 7 Lucas Gass 2023-05-15 14:37:02 UTC
(In reply to Jacob O'Mara from comment #6)
> Enhancement - not backporting to 22.11.x
> 
> Nice work everyone!

Jacob, it looks like you did backport this one? 

https://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=6ce18a8cdb62f279cbfb73bc4f6a46bfd8acc20d
Comment 8 Caroline Cyr La Rose 2023-05-16 16:50:29 UTC
No screenshot to update.