The code for Z3950 popup: 393 /* this function open a popup to search on z3950 server. */ 394 function PopupZ3950() { 395 if( strQuery ){ 396 window.open("/cgi-bin/koha/cataloguing/z3950_search.pl?biblionumber=" + biblionumber + strQuery,"z3950sear ch",'width=740,height=450,location=yes,toolbar=no,scrollbars=yes,resize=yes'); 397 } 398 } 399 Picks a random biblionumber variable Seems to get defined when images are enabled, presumably from verify_cover_images We shouldn't ever be replacing a biblio from the results page, so lets just remove it
Created attachment 143728 [details] [review] Bug 32172: Remove biblionumber param from Z3950 popup on results This param is not defined in routine, who knows whereit comes from To test: 1 - Enable coce and coce intranet, select all providers: https://coce.bywatersolutions.com 2 - Search on staff client 3 - Click Z3950 search 4 - Note url contains a random biblionumber 5 - Apply patch 6 - Repeat 7 - No biblionumber
Created attachment 143739 [details] [review] Bug 32172: Remove biblionumber param from Z3950 popup on results This param is not defined in routine, who knows whereit comes from To test: 1 - Enable coce and coce intranet, select all providers: https://coce.bywatersolutions.com 2 - Search on staff client 3 - Click Z3950 search 4 - Note url contains a random biblionumber 5 - Apply patch 6 - Repeat 7 - No biblionumber Signed-off-by: David Nind <david@davidnind.com>
Created attachment 143951 [details] [review] Bug 32172: Remove biblionumber param from Z3950 popup on results This param is not defined in routine, who knows whereit comes from To test: 1 - Enable coce and coce intranet, select all providers: https://coce.bywatersolutions.com 2 - Search on staff client 3 - Click Z3950 search 4 - Note url contains a random biblionumber 5 - Apply patch 6 - Repeat 7 - No biblionumber Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to master for 22.11. Nice work everyone, thanks!
*** Bug 22548 has been marked as a duplicate of this bug. ***