Bug 32172 - Random biblionumber passed when clicking 'Z3950 SRU/Search' from the search results in staff client
Summary: Random biblionumber passed when clicking 'Z3950 SRU/Search' from the search ...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low critical (vote)
Assignee: Nick Clemens
QA Contact: Testopia
URL:
Keywords:
: 22548 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-11-10 20:58 UTC by Nick Clemens
Modified: 2023-09-23 21:15 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 32172: Remove biblionumber param from Z3950 popup on results (1.42 KB, patch)
2022-11-10 21:01 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 32172: Remove biblionumber param from Z3950 popup on results (1.47 KB, patch)
2022-11-11 02:40 UTC, David Nind
Details | Diff | Splinter Review
Bug 32172: Remove biblionumber param from Z3950 popup on results (1.52 KB, patch)
2022-11-16 12:52 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2022-11-10 20:58:53 UTC
The code for Z3950 popup:
393 /* this function open a popup to search on z3950 server.  */
394 function PopupZ3950() {
395     if( strQuery ){
396         window.open("/cgi-bin/koha/cataloguing/z3950_search.pl?biblionumber=" + biblionumber + strQuery,"z3950sear    ch",'width=740,height=450,location=yes,toolbar=no,scrollbars=yes,resize=yes');
397     }
398 }
399 


Picks a random biblionumber variable

Seems to get defined when images are enabled, presumably from verify_cover_images

We shouldn't ever be replacing a biblio from the results page, so lets just remove it
Comment 1 Nick Clemens 2022-11-10 21:01:22 UTC
Created attachment 143728 [details] [review]
Bug 32172: Remove biblionumber param from Z3950 popup on results

This param is not defined in routine, who knows whereit comes from

To test:
1 - Enable coce and coce intranet, select all providers:
    https://coce.bywatersolutions.com
2 - Search on staff client
3 - Click Z3950 search
4 - Note url contains a random biblionumber
5 - Apply patch
6 - Repeat
7 - No biblionumber
Comment 2 David Nind 2022-11-11 02:40:47 UTC
Created attachment 143739 [details] [review]
Bug 32172: Remove biblionumber param from Z3950 popup on results

This param is not defined in routine, who knows whereit comes from

To test:
1 - Enable coce and coce intranet, select all providers:
    https://coce.bywatersolutions.com
2 - Search on staff client
3 - Click Z3950 search
4 - Note url contains a random biblionumber
5 - Apply patch
6 - Repeat
7 - No biblionumber

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Tomás Cohen Arazi 2022-11-16 12:52:38 UTC
Created attachment 143951 [details] [review]
Bug 32172: Remove biblionumber param from Z3950 popup on results

This param is not defined in routine, who knows whereit comes from

To test:
1 - Enable coce and coce intranet, select all providers:
    https://coce.bywatersolutions.com
2 - Search on staff client
3 - Click Z3950 search
4 - Note url contains a random biblionumber
5 - Apply patch
6 - Repeat
7 - No biblionumber

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 4 Tomás Cohen Arazi 2022-11-16 18:56:48 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 5 Katrin Fischer 2023-09-23 21:15:10 UTC
*** Bug 22548 has been marked as a duplicate of this bug. ***