Bug 32180 - ERM - Mandatory fields don't have the 'required' class on the label
Summary: ERM - Mandatory fields don't have the 'required' class on the label
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: ERM (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact:
URL:
Keywords:
Depends on: 32030
Blocks:
  Show dependency tree / graph
 
Reported: 2022-11-11 15:13 UTC by Jonathan Druart
Modified: 2023-12-28 20:42 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04
Circulation function:

Attachments
Bug 32180: Add required class to labels in ERM (6.59 KB, patch)
2023-03-15 20:50 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Bug 32180: Add required class to labels in ERM (6.65 KB, patch)
2023-03-16 09:35 UTC, Pedro Amorim 		Details | Diff | Splinter Review
Bug 32180: Add required class to labels in ERM (6.72 KB, patch)
2023-03-16 09:58 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2022-11-11 15:13:55 UTC 
At least not all of them, it's inconsistent - https://snipboard.io/pIRQBl.jpg
Comment 1 Lucas Gass (lukeg) 2023-03-15 20:50:53 UTC 
Created attachment 148246 [details] [review]
Bug 32180: Add required class to labels in ERM

To test:
1. Apply patch, yarn build
2. Add/edit Agreemnets, make sure all required fields have a red 'required' label
3. Check 'Add new period', 'Add new user', 'Add new license', 'Add new related agreement'.
4. Add/edit Licenses, make sure all required fields have a red 'required' label.
Comment 2 Pedro Amorim 2023-03-16 09:35:33 UTC 
Created attachment 148253 [details] [review]
Bug 32180: Add required class to labels in ERM

To test:
1. Apply patch, yarn build
2. Add/edit Agreemnets, make sure all required fields have a red 'required' label
3. Check 'Add new period', 'Add new user', 'Add new license', 'Add new related agreement'.
4. Add/edit Licenses, make sure all required fields have a red 'required' label.

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 3 Martin Renvoize (ashimema) 2023-03-16 09:58:55 UTC 
Created attachment 148255 [details] [review]
Bug 32180: Add required class to labels in ERM

To test:
1. Apply patch, yarn build
2. Add/edit Agreemnets, make sure all required fields have a red 'required' label
3. Check 'Add new period', 'Add new user', 'Add new license', 'Add new related agreement'.
4. Add/edit Licenses, make sure all required fields have a red 'required' label.

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize (ashimema) 2023-03-16 09:59:11 UTC 
Great work.. Passing QA
Comment 5 Tomás Cohen Arazi (tcohen) 2023-03-16 19:31:24 UTC 
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Matt Blenkinsop 2023-03-17 17:02:46 UTC 
Nice work everyone!

Pushed to stable for 22.11.x
Comment 7 Lucas Gass (lukeg) 2023-04-21 16:46:55 UTC 
Not needed for 22.05.x, no backport.