This turned up in translations: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt: <span class="notforloan">Not for loan ([% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.notforloan', authorised_value => itemLoo.notforloan ) %] %]) Results in this string: Not for loan (%s %%])
Created attachment 143810 [details] [review] Bug 32185: Fix template typo in opac-reserve.pl This removes the %] showing for not for loan items disappear. To test: * Create a record with multiple items, mark one 'not for loan' * Place an item level request on this record in the OPAC * Make sure you 'Show nonholdable items' * Verify the %] shows in the column with the not for loan status * Apply patch * Verify display is now improved
As this was found translating we can be sure it affects translations, changing a string in the OPAC. Maybe we could do another update to the strings a few days before release to catch such last minute fixed stuff?
Pushed to master for 22.11. Nice work everyone, thanks!