Bug 32185 - Template error in opac-reserve.pl
Summary: Template error in opac-reserve.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords: rel_22_11_candidate
Depends on:
Blocks:
 
Reported: 2022-11-12 13:21 UTC by Katrin Fischer
Modified: 2023-06-08 22:29 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 32185: Fix template typo in opac-reserve.pl (1.79 KB, patch)
2022-11-13 13:33 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-11-12 13:21:03 UTC
This turned up in translations:

koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt: 

<span class="notforloan">Not for loan ([% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.notforloan', authorised_value => itemLoo.notforloan ) %] %])

Results in this string:
Not for loan (%s %%])
Comment 1 Katrin Fischer 2022-11-13 13:33:49 UTC
Created attachment 143810 [details] [review]
Bug 32185: Fix template typo in opac-reserve.pl

This removes the %] showing for not for loan items disappear.

To test:
* Create a record with multiple items, mark one 'not for loan'
* Place an item level request on this record in the OPAC
* Make sure you 'Show nonholdable items'
* Verify the %] shows in the column with the not for loan status
* Apply patch
* Verify display is now improved
Comment 2 Katrin Fischer 2022-11-13 13:34:43 UTC
As this was found translating we can be sure it affects translations, changing a string in the OPAC. Maybe we could do another update to the strings a few days before release to catch such last minute fixed stuff?
Comment 3 Tomás Cohen Arazi 2022-11-14 12:22:38 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!