On the patron categories page, there's a column for "can be guaranteee," that shows a yes or no value. Except it shows "Yes" with a capital "Y" and "no" with a lowercase "n." Per our general style guidelines, that "no" should be capitalized.
Created attachment 143875 [details] [review] Bug 32194: Capitalize "No" values for the patron categories "Can be guarantee" column This fixes the display of the patron categories "Can be guarantee" column so that "No" values have a capital "N". Test plan: 1. Go to Administration > Patrons and circulation > Patron categories. 2. Note that for the "Can be guarantee" column, it shows "Yes" values with a capital "Y" and "no" values with a lowercase "n". 3. Apply the patch. 4. Refresh the page. 5. Note that any "No" values now have a capital "N". 6. Sign off D: Signed-off-by: David Nind <david@davidnind.com>
Created attachment 143878 [details] [review] Bug 32194: Capitalize "No" values for the patron categories "Can be guarantee" column This fixes the display of the patron categories "Can be guarantee" column so that "No" values have a capital "N". Test plan: 1. Go to Administration > Patrons and circulation > Patron categories. 2. Note that for the "Can be guarantee" column, it shows "Yes" values with a capital "Y" and "no" values with a lowercase "n". 3. Apply the patch. 4. Refresh the page. 5. Note that any "No" values now have a capital "N". 6. Sign off D: Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Might have to wait because of string freeze.
This relates to a new feature added to 22.11 in Bug 12446 - Enable an adult to have a guarantor, so only affects master.
I had missed to set this to PQA, but also checked it again now :)
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to 22.11.x for the next release