Bug 32197 - Add page-section to catalog's stock rotation page
Summary: Add page-section to catalog's stock rotation page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 30952
Blocks: 31757
  Show dependency treegraph
 
Reported: 2022-11-14 17:20 UTC by Owen Leonard
Modified: 2023-06-08 22:29 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 32197: Add page-section to catalog's stock rotation page (14.96 KB, patch)
2022-11-14 17:27 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32197: Add page-section to catalog's stock rotation page (15.02 KB, patch)
2022-11-14 18:03 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2022-11-14 17:20:21 UTC
The stock rotation view of a bibliographic record needs to have a page-section div added.
Comment 1 Owen Leonard 2022-11-14 17:27:27 UTC
Created attachment 143850 [details] [review]
Bug 32197: Add page-section to catalog's stock rotation page

This page wraps the content of the stock rotation page in the catalog
with a "page-section" div.

Note: This patch includes indentation changes, so use diff accordingly.

To test you  must have the StockRotation system preference enabled.
Apply the patch and locate a bibliographic record in the catalog.

- Click the "Rota" link in the sidebar.
- Confirm that the table of items on this page is surrounded by a
  container with a white-background.
Comment 2 Katrin Fischer 2022-11-14 18:03:18 UTC
Created attachment 143853 [details] [review]
Bug 32197: Add page-section to catalog's stock rotation page

This page wraps the content of the stock rotation page in the catalog
with a "page-section" div.

Note: This patch includes indentation changes, so use diff accordingly.

To test you  must have the StockRotation system preference enabled.
Apply the patch and locate a bibliographic record in the catalog.

- Click the "Rota" link in the sidebar.
- Confirm that the table of items on this page is surrounded by a
  container with a white-background.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 3 Katrin Fischer 2022-11-14 18:04:07 UTC
And another one bites the dust...!
Comment 4 Tomás Cohen Arazi 2022-11-16 12:40:34 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!