Bug 32214 - Staff interface toolbar - no options when search catalog selected
Summary: Staff interface toolbar - no options when search catalog selected
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 30952
Blocks:
  Show dependency treegraph
 
Reported: 2022-11-15 20:56 UTC by David Nind
Modified: 2023-06-08 22:28 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Screenshot - options empty for search catalog in toolbar (38.64 KB, image/png)
2022-11-15 20:56 UTC, David Nind
Details
Bug 32214: Prevent empty search option block in catalog search header (2.59 KB, patch)
2022-11-16 06:56 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32214: Prevent empty search option block in catalog search header (2.63 KB, patch)
2022-11-16 09:13 UTC, David Nind
Details | Diff | Splinter Review
Bug 32214: Prevent empty search option block in catalog search header (2.69 KB, patch)
2022-11-16 19:08 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Nind 2022-11-15 20:56:39 UTC
Created attachment 143932 [details]
Screenshot - options empty for search catalog in toolbar

There are no options if you select the options/settings icon before the search/arrow button when 'Search catalog' is selected - see the screenshot attached.

Compare this with the patrons area, where there are several options to help you refine your search.

To replicate:
1. In the staff interface toolbar select 'Search catalog'.
2. Click on the options/setting icon before the search arrow.
3. Note that there are no options to select from
Comment 1 Jonathan Druart 2022-11-16 06:56:34 UTC
Created attachment 143934 [details] [review]
Bug 32214: Prevent empty search option block in catalog search header

In the header, if "Search catalog" is selected, there is an "option"
icon to display some filters.
Fitlers are displayed if IntranetCatalogSearchPulldown or
IntranetAddMastheadLibraryPulldown is set. If none are set we should
hide the icon to avoid and empty div to be displayed

Test plan:
Confirm that the icon is only displayed if one of the 2 prefs is turned
on.
Comment 2 David Nind 2022-11-16 09:13:23 UTC
Created attachment 143945 [details] [review]
Bug 32214: Prevent empty search option block in catalog search header

In the header, if "Search catalog" is selected, there is an "option"
icon to display some filters.
Fitlers are displayed if IntranetCatalogSearchPulldown or
IntranetAddMastheadLibraryPulldown is set. If none are set we should
hide the icon to avoid and empty div to be displayed

Test plan:
Confirm that the icon is only displayed if one of the 2 prefs is turned
on.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2022-11-16 19:08:44 UTC
Created attachment 143967 [details] [review]
Bug 32214: Prevent empty search option block in catalog search header

In the header, if "Search catalog" is selected, there is an "option"
icon to display some filters.
Fitlers are displayed if IntranetCatalogSearchPulldown or
IntranetAddMastheadLibraryPulldown is set. If none are set we should
hide the icon to avoid and empty div to be displayed

Test plan:
Confirm that the icon is only displayed if one of the 2 prefs is turned
on.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2022-11-16 19:30:10 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!