Bug 32217 - Typo: Error authenticating in external provider
Summary: Typo: Error authenticating in external provider
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Philip Orr
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2022-11-15 22:01 UTC by Katrin Fischer
Modified: 2023-12-28 20:44 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05
Circulation function:

Attachments
Bug 32217: Fixed typo in error message for authentication providers (1.18 KB, patch)
2023-03-30 08:40 UTC, Philip Orr 		Details | Diff | Splinter Review
Bug 32217: Fixed typo in error message for authentication providers (1.18 KB, patch)
2023-03-30 08:46 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Bug 32217: Fixed typo in error message for authentication providers (1.24 KB, patch)
2023-03-30 08:54 UTC, Victor Grousset/tuxayo 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-11-15 22:01:45 UTC 
Found while translating:

koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt:11

%sTwo-factor authentication%s %sTwo-factor authentication setup%s %sLog in to Koha%s %sThis account has been locked. %sInvalid username or password%s %sIP address change%s %sSession timed out%s %sAccess denied%s %sError authenticating in external provider%s › Koha␠

Should it be: Error authenticating against external provider?
Comment 1 David Cook 2022-11-15 22:42:26 UTC 
I did a bit of Googling for phrasing and I think maybe "Error authenticating with X" seems to be the norm.
Comment 2 Philip Orr 2023-03-30 08:40:50 UTC 
Created attachment 148956 [details] [review]
Bug 32217: Fixed typo in error message for authentication providers

Changed the error message for authentication providers to use
"in" instead of "with".

To Test:
Review the patch file closely and verify changes.
Comment 3 Martin Renvoize (ashimema) 2023-03-30 08:46:26 UTC 
Created attachment 148967 [details] [review]
Bug 32217: Fixed typo in error message for authentication providers

Changed the error message for authentication providers to use
"in" instead of "with".

To Test:
Review the patch file closely and verify changes.
Comment 4 Martin Renvoize (ashimema) 2023-03-30 08:46:58 UTC 
Thanks for the patch Philip, looks perfect.

Welcome to the team.. signing off.
Comment 5 Victor Grousset/tuxayo 2023-03-30 08:54:39 UTC 
Created attachment 148968 [details] [review]
Bug 32217: Fixed typo in error message for authentication providers

Changed the error message for authentication providers to use
"in" instead of "with".

To Test:
Review the patch file closely and verify changes.

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 6 Victor Grousset/tuxayo 2023-03-30 08:56:47 UTC 
oops, wrong tab >_<
Comment 7 Tomás Cohen Arazi (tcohen) 2023-03-30 10:14:51 UTC 
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 8 Matt Blenkinsop 2023-04-11 11:12:19 UTC 
Nice work everyone!

Pushed to stable for 22.11.x