Since the password can no longer be shown in notices, borrowers.password should be removed from the notice templates.
Hi Christopher, do you mean the ability to add it using the list in the notice editor or do you mean one of the sample notices? The latter should have been done.
Created attachment 143974 [details] borrowers.password
(In reply to Katrin Fischer from comment #1) > Hi Christopher, do you mean the ability to add it using the list in the > notice editor or do you mean one of the sample notices? The latter should > have been done. I mean the list (see attachment). Doesn't make sense to have it there anymore.
Thx for clarifying!
Created attachment 144284 [details] [review] Bug 32221: Borrowers.password should no longer be an option When creating a notice template the user has the option to add the borrower's password to the template. This should be removed as the password should not be an option to be added to a notice. Test plan: 1) Navigate to Tools > Notices and slips 2) Either create a new notice or edit an existing notice 3) Observe that in the list of fields available to insert into the message body, there is the option for "borrowers.password" 4) Apply patch 5) Navigate to the same menu 6) Observe that the "borrowers.password" option is now no longer visible
Created attachment 144306 [details] [review] Bug 32221: Borrowers.password should no longer be an option When creating a notice template the user has the option to add the borrower's password to the template. This should be removed as the password should not be an option to be added to a notice. Test plan: 1) Navigate to Tools > Notices and slips 2) Either create a new notice or edit an existing notice 3) Observe that in the list of fields available to insert into the message body, there is the option for "borrowers.password" 4) Apply patch 5) Navigate to the same menu 6) Observe that the "borrowers.password" option is now no longer visible Signed-off-by: David Nind <david@davidnind.com>
Matt, I have added you as the assignee for the bug.
Created attachment 144702 [details] [review] Bug 32221: Borrowers.password should no longer be an option When creating a notice template the user has the option to add the borrower's password to the template. This should be removed as the password should not be an option to be added to a notice. Test plan: 1) Navigate to Tools > Notices and slips 2) Either create a new notice or edit an existing notice 3) Observe that in the list of fields available to insert into the message body, there is the option for "borrowers.password" 4) Apply patch 5) Navigate to the same menu 6) Observe that the "borrowers.password" option is now no longer visible Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Keep up the good work! Pushed to 23.05.x for the next release
Nice work everyone! Pushed to stable for 22.11.x
Backported to 22.05.x for upcoming 22.05.10
applied to 21.11.x for 21.11.16
Not backported to 21.05.x