Bug 32230 - Capitalization: Manage Domains
Summary: Capitalization: Manage Domains
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2022-11-16 11:13 UTC by Katrin Fischer
Modified: 2023-12-28 20:44 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.03


Attachments
Bug 32230: Fix capitalization of "Manage Domains" (2.51 KB, patch)
2023-02-05 01:09 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32230: Fix capitalization of "Manage Domains" (2.56 KB, patch)
2023-02-06 13:53 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32230: Fix capitalization of "Manage Domains" (2.62 KB, patch)
2023-02-06 16:10 UTC, Lucas Gass
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-11-16 11:13:30 UTC
Found while translating:

Manage Domains
koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt:406
Comment 1 Katrin Fischer 2023-02-05 01:09:41 UTC
Created attachment 146183 [details] [review]
Bug 32230: Fix capitalization of "Manage Domains"

To test:
* Go to administration > Identity providers
* Add a new identity provider and fill out all required form fields
  Hint: you can use the buttons to add example JSON to the input fields
* Save
* Verify the entry in the table now shows a "Manage Domains" button
* Apply patch
* Verify the button now reads correctly: "Manage domains"
Comment 2 Owen Leonard 2023-02-06 13:53:47 UTC
Created attachment 146273 [details] [review]
Bug 32230: Fix capitalization of "Manage Domains"

To test:
* Go to administration > Identity providers
* Add a new identity provider and fill out all required form fields
  Hint: you can use the buttons to add example JSON to the input fields
* Save
* Verify the entry in the table now shows a "Manage Domains" button
* Apply patch
* Verify the button now reads correctly: "Manage domains"

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Lucas Gass 2023-02-06 16:10:57 UTC
Created attachment 146286 [details] [review]
Bug 32230: Fix capitalization of "Manage Domains"

To test:
* Go to administration > Identity providers
* Add a new identity provider and fill out all required form fields
  Hint: you can use the buttons to add example JSON to the input fields
* Save
* Verify the entry in the table now shows a "Manage Domains" button
* Apply patch
* Verify the button now reads correctly: "Manage domains"

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 Tomás Cohen Arazi 2023-02-06 21:35:40 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Matt Blenkinsop 2023-02-07 15:23:59 UTC
Nice work everyone!

Pushed to stable for 22.11.x