Bug 32236 - Batch item modification - alignment of tick box for 'Use default values'
Summary: Batch item modification - alignment of tick box for 'Use default values'
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords:
Depends on: 30952
Blocks:
  Show dependency treegraph
 
Reported: 2022-11-16 19:13 UTC by David Nind
Modified: 2023-06-08 22:32 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.01


Attachments
Bug 32236: Fix alignment of checkbox "Use default values" for item batch modification (1.96 KB, patch)
2022-11-16 21:51 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32236: Fix alignment of checkbox "Use default values" for item batch modification (2.01 KB, patch)
2022-11-16 22:38 UTC, David Nind
Details | Diff | Splinter Review
Bug 32236: Fix alignment of checkbox "Use default values" for item batch modification (2.01 KB, patch)
2022-11-22 17:30 UTC, Lucas Gass
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Nind 2022-11-16 19:13:23 UTC
For the Cataloguing > Batch item modification form - 'Use default values' section: the tick box is on the left instead of the right.
Comment 1 Katrin Fischer 2022-11-16 21:51:42 UTC
Created attachment 143973 [details] [review]
Bug 32236: Fix alignment of checkbox "Use default values" for item batch modification

This moves the label to the right in front of the checkbox.
It also shortens the label by adding an additional longer hint text.

To test:
* Go to cataloguing > item batch modification
* On the first page of the tool, look at the checkbox at the bottom
* Apply the patch
* Verify changes
Comment 2 Katrin Fischer 2022-11-16 21:52:39 UTC
This solution has one disadvantage: It adds a new string. But I didn't like how squashed the label looked in either position, forced on multiple lines.
Comment 3 David Nind 2022-11-16 22:38:17 UTC
Created attachment 143977 [details] [review]
Bug 32236: Fix alignment of checkbox "Use default values" for item batch modification

This moves the label to the right in front of the checkbox.
It also shortens the label by adding an additional longer hint text.

To test:
* Go to cataloguing > item batch modification
* On the first page of the tool, look at the checkbox at the bottom
* Apply the patch
* Verify changes

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Lucas Gass 2022-11-22 17:28:14 UTC
(In reply to Katrin Fischer from comment #2)
> This solution has one disadvantage: It adds a new string. But I didn't like
> how squashed the label looked in either position, forced on multiple lines.

One more string, yes. It is a much cleaner look!
Comment 5 Lucas Gass 2022-11-22 17:30:05 UTC
Created attachment 144170 [details] [review]
Bug 32236: Fix alignment of checkbox "Use default values" for item batch modification

This moves the label to the right in front of the checkbox.
It also shortens the label by adding an additional longer hint text.

To test:
* Go to cataloguing > item batch modification
* On the first page of the tool, look at the checkbox at the bottom
* Apply the patch
* Verify changes

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 Katrin Fischer 2022-11-22 22:31:49 UTC
Thx, Lucas! I think you forgot your sign-off line?
Comment 7 Tomás Cohen Arazi 2022-12-01 13:04:42 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 8 Matt Blenkinsop 2022-12-05 12:06:20 UTC
Nice work everyone!

Pushed to stable for 22.11.x