For the Cataloguing > Batch item modification form - 'Use default values' section: the tick box is on the left instead of the right.
Created attachment 143973 [details] [review] Bug 32236: Fix alignment of checkbox "Use default values" for item batch modification This moves the label to the right in front of the checkbox. It also shortens the label by adding an additional longer hint text. To test: * Go to cataloguing > item batch modification * On the first page of the tool, look at the checkbox at the bottom * Apply the patch * Verify changes
This solution has one disadvantage: It adds a new string. But I didn't like how squashed the label looked in either position, forced on multiple lines.
Created attachment 143977 [details] [review] Bug 32236: Fix alignment of checkbox "Use default values" for item batch modification This moves the label to the right in front of the checkbox. It also shortens the label by adding an additional longer hint text. To test: * Go to cataloguing > item batch modification * On the first page of the tool, look at the checkbox at the bottom * Apply the patch * Verify changes Signed-off-by: David Nind <david@davidnind.com>
(In reply to Katrin Fischer from comment #2) > This solution has one disadvantage: It adds a new string. But I didn't like > how squashed the label looked in either position, forced on multiple lines. One more string, yes. It is a much cleaner look!
Created attachment 144170 [details] [review] Bug 32236: Fix alignment of checkbox "Use default values" for item batch modification This moves the label to the right in front of the checkbox. It also shortens the label by adding an additional longer hint text. To test: * Go to cataloguing > item batch modification * On the first page of the tool, look at the checkbox at the bottom * Apply the patch * Verify changes Signed-off-by: David Nind <david@davidnind.com>
Thx, Lucas! I think you forgot your sign-off line?
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x