Bug 32237 - Batch delete records "no record IDs defined"
Summary: Batch delete records "no record IDs defined"
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Lists (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: geraud.frappier
QA Contact: Marcel de Rooy
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2022-11-16 21:43 UTC by geraud.frappier
Modified: 2023-12-28 20:43 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.10


Attachments
Bug 32237 : Batch delete records "no record IDs defined". List of records not shown. (1.14 KB, patch)
2022-11-16 22:02 UTC, geraud.frappier
Details | Diff | Splinter Review
Bug 32237: Fix using a list as base for batch record deletion (1.70 KB, patch)
2022-11-16 22:12 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32237: Fix using a list as base for batch record deletion (1.80 KB, patch)
2022-11-18 09:10 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description geraud.frappier 2022-11-16 21:43:14 UTC
To test : 
1. Go to Lists in the intranet.
2. Add a list by clicking on "New list". Choose a random name for it and select private or public and save.
3.Add one or more items into it and save.
4.Go back to the main page and select "Cataloging".
5.Go to "Batch record deletion".
6.In "upload a file" select "Select a list of records" and choose a list and keep the Bibliographic on.
7.Select continue and see that the list of records is not shown.
Comment 1 Katrin Fischer 2022-11-16 21:55:03 UTC
Confirmed on master.
Comment 2 geraud.frappier 2022-11-16 22:02:52 UTC
Created attachment 143975 [details] [review]
Bug 32237 : Batch delete records "no record IDs defined". List of records not shown.

To test patch carry out the same procedure.
Comment 3 Katrin Fischer 2022-11-16 22:05:11 UTC
Hi Geraud, please add a problem/solution description and the full test plans to the commit messages. This might be helpful: https://wiki.koha-community.org/wiki/Commit_messages
Comment 4 Katrin Fischer 2022-11-16 22:12:42 UTC
Created attachment 143976 [details] [review]
Bug 32237: Fix using a list as base for batch record deletion

When a list was used to select records for batch deletion, the
record IDs were no longer found.

To test:

1. Go to Lists in the intranet.
2. Add a list by clicking on "New list". Choose a random name for it and select private or public and save.
3.Add one or more items into it and save.
4.Go back to the main page and select "Cataloging".
5.Go to "Batch record deletion".
6.In "upload a file" select "Select a list of records" and choose a list and keep the Bibliographic on.
7.Select continue and see that the list of records is not shown.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Marcel de Rooy 2022-11-18 09:07:10 UTC
QA: Looking here
Comment 6 Marcel de Rooy 2022-11-18 09:10:46 UTC
Created attachment 144049 [details] [review]
Bug 32237: Fix using a list as base for batch record deletion

When a list was used to select records for batch deletion, the
record IDs were no longer found.

To test:

1. Go to Lists in the intranet.
2. Add a list by clicking on "New list". Choose a random name for it and select private or public and save.
3.Add one or more items into it and save.
4.Go back to the main page and select "Cataloging".
5.Go to "Batch record deletion".
6.In "upload a file" select "Select a list of records" and choose a list and keep the Bibliographic on.
7.Select continue and see that the list of records is not shown.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 7 Tomás Cohen Arazi 2022-11-22 19:40:30 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 8 hebah 2022-12-28 16:54:09 UTC
Any chance this can be backported to 22.05?
Comment 9 Jennifer Marlatt 2022-12-28 17:22:56 UTC
Yes, please! I would love to see this backported to 22.05. I use this feature frequently.
Comment 10 jennifer.bauserman 2023-01-09 17:07:18 UTC
Please backport 22.05!
Comment 11 Sarah Cornell 2023-02-09 01:28:05 UTC
same here!  We just discovered it wasn't working in 22.05.07.
Comment 12 Lucas Gass 2023-02-24 13:42:51 UTC
Backported to 22.05.x for upcoming 22.05.10
Comment 13 Arthur Suzuki 2023-02-28 07:51:10 UTC
can't reproduce on 21.11.x, won't backport