Bug 32238 - Add page-section to label creator pages
Summary: Add page-section to label creator pages
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL: /cgi-bin/koha/labels/label-edit-batch...
Keywords:
Depends on: 30952
Blocks: 31757
  Show dependency treegraph
 
Reported: 2022-11-16 23:15 UTC by Katrin Fischer
Modified: 2023-06-08 22:32 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 32238: Add page-section to label creator pages (18.89 KB, patch)
2022-11-17 19:37 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32238: Add page-section to label creator pages (18.94 KB, patch)
2022-11-17 20:04 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-11-16 23:15:52 UTC
When printing a batch in the label creator, the list of items is missing the page section.
Comment 1 Owen Leonard 2022-11-17 19:37:00 UTC
Created attachment 144032 [details] [review]
Bug 32238: Add page-section to label creator pages

This patch modifies two label creator templates so that a .page-section
container is used to wrap main content.

To test, apply the patch and go to Cataloging -> Label creator.

 - Click Manage -> Label batches.
   - The display of existing batches should look correct.
 - Click "Edit" on one of the label batches.
   - If necessary, submit a set of barcodes or item numbers to add to
     the batch.
   - The display of items in the table of items should look correct.
Comment 2 Katrin Fischer 2022-11-17 20:04:01 UTC
Created attachment 144036 [details] [review]
Bug 32238: Add page-section to label creator pages

This patch modifies two label creator templates so that a .page-section
container is used to wrap main content.

To test, apply the patch and go to Cataloging -> Label creator.

 - Click Manage -> Label batches.
   - The display of existing batches should look correct.
 - Click "Edit" on one of the label batches.
   - If necessary, submit a set of barcodes or item numbers to add to
     the batch.
   - The display of items in the table of items should look correct.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 3 Katrin Fischer 2022-11-17 20:04:31 UTC
Straight to Tomas with this one.
Comment 4 Tomás Cohen Arazi 2022-11-22 19:40:36 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!