Bug 32239 - Report options for adding groups/sub groups are misaligned
Summary: Report options for adding groups/sub groups are misaligned
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Lucas Gass
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 30952
Blocks:
  Show dependency treegraph
 
Reported: 2022-11-17 00:21 UTC by Katrin Fischer
Modified: 2023-12-28 20:43 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.03


Attachments
Bug 32239: Remove uneeded CSS from reports.css (2.37 KB, patch)
2023-01-09 18:35 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 32239: Remove uneeded CSS from reports.css (2.41 KB, patch)
2023-01-09 23:23 UTC, David Nind
Details | Diff | Splinter Review
Bug 32239: Remove uneeded CSS from reports.css (2.46 KB, patch)
2023-01-30 22:35 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-11-17 00:21:13 UTC
When adding a new SQL report, the options for adding/creating groups and sub groups are misaligned: 

https://snipboard.io/Nfpu0d.jpg

There is a lot of space between the label and the pull down that belongs to it.
Comment 1 Lucas Gass 2023-01-09 18:31:47 UTC
It looks like this is because of some CSS in reports.css. I do not think it is needed. It looks like reports.css is used in two places:

koha-tmpl/intranet-tmpl/prog/en/includes/mana/mana-report-search-result.inc:[% Asset.css("css/reports.css") | $raw %]
koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt:[% Asset.css("css/reports.css") | $raw %]
Comment 2 Lucas Gass 2023-01-09 18:35:16 UTC
Created attachment 145158 [details] [review]
Bug 32239: Remove uneeded CSS from reports.css

To test:
1. Apply patch.
2. When adding a new SQL report, the options for adding/creating groups and sub groups should be aligned properly.
3. Turn on Mana and look at Mana Knowledge Base report search results to make sure everything is still properly aligned there.
Comment 3 David Nind 2023-01-09 23:23:15 UTC
Created attachment 145169 [details] [review]
Bug 32239: Remove uneeded CSS from reports.css

To test:
1. Apply patch.
2. When adding a new SQL report, the options for adding/creating groups and sub groups should be aligned properly.
3. Turn on Mana and look at Mana Knowledge Base report search results to make sure everything is still properly aligned there.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Katrin Fischer 2023-01-30 22:35:17 UTC
Created attachment 145823 [details] [review]
Bug 32239: Remove uneeded CSS from reports.css

To test:
1. Apply patch.
2. When adding a new SQL report, the options for adding/creating groups and sub groups should be aligned properly.
3. Turn on Mana and look at Mana Knowledge Base report search results to make sure everything is still properly aligned there.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi 2023-01-31 14:09:26 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Jacob O'Mara 2023-01-31 18:10:55 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 7 Lucas Gass 2023-02-03 22:18:24 UTC
Missing dependencies for 22.05.x, no backport.