Bug 32253 - Advanced cataloging editor doesn't load every line initially
Summary: Advanced cataloging editor doesn't load every line initially
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Lucas Gass (lukeg)
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 31863
Blocks:
  Show dependency treegraph
 
Reported: 2022-11-17 16:47 UTC by Lucas Gass (lukeg)
Modified: 2023-12-28 20:44 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06,22.05.13
Circulation function:


Attachments
Bug 32253: Load all CodeMirror lines initially when using advanced editor (1.19 KB, patch)
2023-05-01 22:15 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 32253: Load all CodeMirror lines initially when using advanced editor (1.24 KB, patch)
2023-05-01 23:09 UTC, David Nind
Details | Diff | Splinter Review
Bug 32253: Load all CodeMirror lines initially when using advanced editor (1.29 KB, patch)
2023-05-02 21:37 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2022-11-17 16:47:49 UTC
If you load the advanced cataloging editor with a record that has more than 25 lines not all the lines will load initially. Once you add focus to the CodeMirror instance those lines do load but they should all load intially.

To recreate:
1. Have advanced editor turned on. 
2. Load a record with many lines and see that not all the lines appear until you click on the visible ones.
Comment 1 Lucas Gass (lukeg) 2023-05-01 22:15:27 UTC
Created attachment 150476 [details] [review]
Bug 32253: Load all CodeMirror lines initially when using advanced editor

To test:
1. Have advanced editor turned on.
2. Load a record with many lines and see that not all the lines appear until you click on the visible ones.
3. Apply patch and try again
4. All lines should load.
Comment 2 David Nind 2023-05-01 23:09:07 UTC
Created attachment 150483 [details] [review]
Bug 32253: Load all CodeMirror lines initially when using advanced editor

To test:
1. Have advanced editor turned on.
2. Load a record with many lines and see that not all the lines appear until you click on the visible ones.
3. Apply patch and try again
4. All lines should load.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2023-05-01 23:10:08 UTC
Testing notes (using KTD):

1. Used biblionumber = 248 - this has more than 25 lines in the advanced editor.
Comment 4 Katrin Fischer 2023-05-02 21:37:08 UTC
Created attachment 150536 [details] [review]
Bug 32253: Load all CodeMirror lines initially when using advanced editor

To test:
1. Have advanced editor turned on.
2. Load a record with many lines and see that not all the lines appear until you click on the visible ones.
3. Apply patch and try again
4. All lines should load.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2023-05-02 21:37:23 UTC
Small fix, great effect, thanks!
Comment 6 Tomás Cohen Arazi (tcohen) 2023-05-05 12:16:57 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Martin Renvoize (ashimema) 2023-05-11 12:25:33 UTC
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release
Comment 8 Lucas Gass (lukeg) 2023-05-15 22:36:53 UTC
Backported to 22.05.x for upcoming 22.05.13