Bug 32263 - Capitalization: ...and on the Libraries page in the OPAC.
Summary: Capitalization: ...and on the Libraries page in the OPAC.
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Philip Orr
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2022-11-18 10:35 UTC by Katrin Fischer
Modified: 2023-12-28 20:42 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05


Attachments
Bug 32263: Fix capitalization for "...and on the Libraries page in the OPAC." (1.53 KB, patch)
2023-03-30 12:23 UTC, Philip Orr
Details | Diff | Splinter Review
Bug 32263: Fix capitalization for "...and on the Libraries page in the OPAC." (1.58 KB, patch)
2023-03-30 12:38 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32263: Fix capitalization for "...and on the Libraries page in the OPAC." (1.64 KB, patch)
2023-04-01 22:48 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-11-18 10:35:17 UTC
Full string:

Set to 'yes' to show this library as a search option and on the Libraries page in the OPAC.

koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt:303
Comment 1 Philip Orr 2023-03-30 12:23:46 UTC
Created attachment 148975 [details] [review]
Bug 32263: Fix capitalization for "...and on the Libraries page in the OPAC."

Small fix to correct the capitalization in library editing mode to display
"...and on the libraries page in the OPAC.".

To Test:
1. apply patch
2. navigate to Administration -> Libraries
3. edit any library
4. confirm that the note underneath the option for "Public" now displays with
   the correct capitalization ("... on the libraries page...")
Comment 2 Owen Leonard 2023-03-30 12:38:06 UTC
Created attachment 148979 [details] [review]
Bug 32263: Fix capitalization for "...and on the Libraries page in the OPAC."

Small fix to correct the capitalization in library editing mode to
display "...and on the libraries page in the OPAC.".

To Test:
1. apply patch
2. navigate to Administration -> Libraries
3. edit any library
4. confirm that the note underneath the option for "Public" now
   displays with the correct capitalization ("... on the libraries
   page...")

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Nick Clemens 2023-04-01 22:48:57 UTC
Created attachment 149069 [details] [review]
Bug 32263: Fix capitalization for "...and on the Libraries page in the OPAC."

Small fix to correct the capitalization in library editing mode to
display "...and on the libraries page in the OPAC.".

To Test:
1. apply patch
2. navigate to Administration -> Libraries
3. edit any library
4. confirm that the note underneath the option for "Public" now
   displays with the correct capitalization ("... on the libraries
   page...")

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Tomás Cohen Arazi 2023-04-06 12:30:25 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Jacob O'Mara 2023-04-16 20:37:17 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 6 Lucas Gass 2023-05-05 21:28:25 UTC
Doesn't apply clean in 22.05.x, no backport.