We need to add page section divs to Cataloguing - Label Creator - Manage Labels to ensure proper contrast of even odd rows in tables.
Created attachment 144075 [details] [review] Bug 32270: add page section to label management Test plan: Navigate to Cataloguing - Label Creator - Manage Labels Observe the missing page section surrounding the table Apply patch Observe that missing page section has now appeared
Created attachment 144078 [details] [review] Bug 32270: add page section to label management Test plan: Navigate to Cataloguing - Label Creator - Manage Labels Observe the missing page section surrounding the table Apply patch Observe that missing page section has now appeared Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Welcome Matt and Jacob :)
Created attachment 144087 [details] [review] Bug 32270: add page section to label layouts Test plan: Navigate to Cataloguing - Label creator - Manage label layots Observe the missing page section surrounding the table Apply patch Observe that missing page section has now appeared Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 144148 [details] [review] Bug 32270: Add page section to label layouts Test plan: 1) Navigate to `Cataloguing > Label creator > Manage label layouts` 2) Observe the missing page section surrounding the table 3) Apply patch 4) Observe that missing page section has now appeared Mentored-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Sponsored-by: PTFS Europe Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Minor tidy up of the commit message, adding sponsor and mentor details.
Pushed to master for 22.11. Nice work everyone, thanks!