Bug 32270 - Add page-section to label creator - manage label layouts
Summary: Add page-section to label creator - manage label layouts
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Jacob O'Mara
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-18 15:43 UTC by Matt Blenkinsop
Modified: 2023-06-08 22:32 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 32270: add page section to label management (1.30 KB, patch)
2022-11-18 16:43 UTC, Jacob O'Mara
Details | Diff | Splinter Review
Bug 32270: add page section to label management (1.36 KB, patch)
2022-11-18 19:31 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 32270: add page section to label layouts (1.48 KB, patch)
2022-11-19 18:16 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32270: Add page section to label layouts (1.52 KB, patch)
2022-11-22 11:49 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Blenkinsop 2022-11-18 15:43:12 UTC
We need to add page section divs to Cataloguing - Label Creator - Manage Labels to ensure proper contrast of even odd rows in tables.
Comment 1 Jacob O'Mara 2022-11-18 16:43:29 UTC
Created attachment 144075 [details] [review]
Bug 32270: add page section to label management

Test plan:
Navigate to Cataloguing - Label Creator - Manage Labels
Observe the missing page section surrounding the table
Apply patch
Observe that missing page section has now appeared
Comment 2 ByWater Sandboxes 2022-11-18 19:31:01 UTC
Created attachment 144078 [details] [review]
Bug 32270: add page section to label management

Test plan:
Navigate to Cataloguing - Label Creator - Manage Labels
Observe the missing page section surrounding the table
Apply patch
Observe that missing page section has now appeared

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 3 Katrin Fischer 2022-11-19 18:10:50 UTC
Welcome Matt and Jacob  :)
Comment 4 Katrin Fischer 2022-11-19 18:16:03 UTC
Created attachment 144087 [details] [review]
Bug 32270: add page section to label layouts

Test plan:
Navigate to Cataloguing - Label creator - Manage label layots
Observe the missing page section surrounding the table
Apply patch
Observe that missing page section has now appeared

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Martin Renvoize 2022-11-22 11:49:30 UTC
Created attachment 144148 [details] [review]
Bug 32270: Add page section to label layouts

Test plan:
1) Navigate to `Cataloguing > Label creator > Manage label layouts`
2) Observe the missing page section surrounding the table
3) Apply patch
4) Observe that missing page section has now appeared

Mentored-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Sponsored-by: PTFS Europe
Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Martin Renvoize 2022-11-22 11:50:37 UTC
Minor tidy up of the commit message, adding sponsor and mentor details.
Comment 7 Tomás Cohen Arazi 2022-11-22 12:31:25 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!