C4::AuthoritiesMarc method GetAuthorizedHeading is not exported thus it is called in other modules : > git grep GetAuthorizedHeading C4/AuthoritiesMarc.pm:=head2 GetAuthorizedHeading C4/AuthoritiesMarc.pm: $heading = &GetAuthorizedHeading({ record => $record, authid => $authid }) C4/AuthoritiesMarc.pm:sub GetAuthorizedHeading { C4/Breeding.pm: $heading = C4::AuthoritiesMarc::GetAuthorizedHeading({ record => $marcrecord }); C4/ImportBatch.pm: $row->{'authorized_heading'} = C4::AuthoritiesMarc::GetAuthorizedHeading( { authid => $row->{'candidate_match_id'} } ); C4/ImportBatch.pm: my $authorized_heading = C4::AuthoritiesMarc::GetAuthorizedHeading({ record => $marc_record }); It should be exported.
The main cause for us it that we want to call it in our plugin : https://github.com/biblibre/koha-plugin-idref
Created attachment 144085 [details] [review] Bug 32279: Add GetAuthorizedHeading method export C4::AuthoritiesMarc C4::AuthoritiesMarc method GetAuthorizedHeading is not exported thus it is called in other modules : > git grep GetAuthorizedHeading C4/AuthoritiesMarc.pm:=head2 GetAuthorizedHeading C4/AuthoritiesMarc.pm: $heading = &GetAuthorizedHeading({ record => $record, authid => $authid }) C4/AuthoritiesMarc.pm:sub GetAuthorizedHeading { C4/Breeding.pm: $heading = C4::AuthoritiesMarc::GetAuthorizedHeading({ record => $marcrecord }); C4/ImportBatch.pm: $row->{'authorized_heading'} = C4::AuthoritiesMarc::GetAuthorizedHeading( { authid => $row->{'candidate_match_id'} } ); C4/ImportBatch.pm: my $authorized_heading = C4::AuthoritiesMarc::GetAuthorizedHeading({ record => $marc_record }); This patch adds it to be exported. For example for use in Koha plugins. Test plan : Check import of authorities from a file is OK
Created attachment 147815 [details] [review] Bug 32279: Add GetAuthorizedHeading method export C4::AuthoritiesMarc C4::AuthoritiesMarc method GetAuthorizedHeading is not exported thus it is called in other modules : > git grep GetAuthorizedHeading C4/AuthoritiesMarc.pm:=head2 GetAuthorizedHeading C4/AuthoritiesMarc.pm: $heading = &GetAuthorizedHeading({ record => $record, authid => $authid }) C4/AuthoritiesMarc.pm:sub GetAuthorizedHeading { C4/Breeding.pm: $heading = C4::AuthoritiesMarc::GetAuthorizedHeading({ record => $marcrecord }); C4/ImportBatch.pm: $row->{'authorized_heading'} = C4::AuthoritiesMarc::GetAuthorizedHeading( { authid => $row->{'candidate_match_id'} } ); C4/ImportBatch.pm: my $authorized_heading = C4::AuthoritiesMarc::GetAuthorizedHeading({ record => $marc_record }); This patch adds it to be exported. For example for use in Koha plugins. Test plan : Check import of authorities from a file is OK Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Created attachment 148836 [details] [review] Bug 32279: Add GetAuthorizedHeading method export C4::AuthoritiesMarc C4::AuthoritiesMarc method GetAuthorizedHeading is not exported thus it is called in other modules : > git grep GetAuthorizedHeading C4/AuthoritiesMarc.pm:=head2 GetAuthorizedHeading C4/AuthoritiesMarc.pm: $heading = &GetAuthorizedHeading({ record => $record, authid => $authid }) C4/AuthoritiesMarc.pm:sub GetAuthorizedHeading { C4/Breeding.pm: $heading = C4::AuthoritiesMarc::GetAuthorizedHeading({ record => $marcrecord }); C4/ImportBatch.pm: $row->{'authorized_heading'} = C4::AuthoritiesMarc::GetAuthorizedHeading( { authid => $row->{'candidate_match_id'} } ); C4/ImportBatch.pm: my $authorized_heading = C4::AuthoritiesMarc::GetAuthorizedHeading({ record => $marc_record }); This patch adds it to be exported. For example for use in Koha plugins. Test plan : Check import of authorities from a file is OK Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.
Backported to 22.05.x for upcoming 22.05.12
applied to 21.11.x for 21.11.20