Bug 32282 - Capitalization: User id
Summary: Capitalization: User id
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Andrew Auld
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2022-11-19 13:22 UTC by Katrin Fischer
Modified: 2024-07-04 20:37 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.01
Circulation function:


Attachments
Bug 32282: Fixed capitalisation of ID in User ID (1.51 KB, patch)
2022-11-22 14:38 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 32282: Fixed capitalisation of ID in User ID (1.58 KB, patch)
2022-11-22 16:19 UTC, Amit Gupta
Details | Diff | Splinter Review
Bug 32282: Fixed capitalisation of ID in User ID (1.63 KB, patch)
2022-12-04 13:06 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-11-19 13:22:05 UTC
ID is an abbreviation and as such should always be capitalized:

User id => User ID

koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt:406
Comment 1 Martin Renvoize (ashimema) 2022-11-22 14:38:21 UTC
Created attachment 144157 [details] [review]
Bug 32282: Fixed capitalisation of ID in User ID

Test plan
Step 1: go to admin>identity providers
Step 2: click 'new identity provider'
Step 3: check map point drop-down
Step 4: verify that User id is written 'User id'
Step 5: apply patch
Step 6: repeat 1-3
Step 7: verify that User ID is written 'User ID'
Comment 2 Martin Renvoize (ashimema) 2022-11-22 14:39:18 UTC
Another one submitted via github and transferred via my dev systems
Comment 3 Amit Gupta 2022-11-22 16:19:14 UTC
Created attachment 144163 [details] [review]
Bug 32282: Fixed capitalisation of ID in User ID

Test plan
Step 1: go to admin>identity providers
Step 2: click 'new identity provider'
Step 3: check map point drop-down
Step 4: verify that User id is written 'User id'
Step 5: apply patch
Step 6: repeat 1-3
Step 7: verify that User ID is written 'User ID'
Comment 4 Katrin Fischer 2022-12-04 13:06:36 UTC
Created attachment 144420 [details] [review]
Bug 32282: Fixed capitalisation of ID in User ID

Test plan
Step 1: go to admin>identity providers
Step 2: click 'new identity provider'
Step 3: check map point drop-down
Step 4: verify that User id is written 'User id'
Step 5: apply patch
Step 6: repeat 1-3
Step 7: verify that User ID is written 'User ID'

Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi (tcohen) 2022-12-07 14:39:44 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Jacob O'Mara 2022-12-08 11:11:29 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.