opac is an abbreviation and needs to be written in capitals: OPAC koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_provider_domains.tt:261 opac users of this domain to login with this identity provider
Created attachment 144158 [details] [review] Bug 32283: Correct capitalisation of opac > OPAC Test plan Step 1: Navigate to admin>Identity Providers Step 2: Add new domain Step 3: For 'Allow opac' setting, verify that opac is lower case in both label and description Step 4: Apply patch Step 5: Navigate to admin>Identity Providers Step 6: Add new domain Step 7: For 'Allow OPAC' setting, verify that OPAC is upper case in both label and description
Another one coming in via github pull request and then transferred via my systems.
I actually fixed a label on this as well as the description. See test plan.
Created attachment 144180 [details] [review] Bug 32283: Correct capitalisation of opac > OPAC Test plan Step 1: Navigate to admin>Identity Providers Step 2: Add new domain Step 3: For 'Allow opac' setting, verify that opac is lower case in both label and description Step 4: Apply patch Step 5: Navigate to admin>Identity Providers Step 6: Add new domain Step 7: For 'Allow OPAC' setting, verify that OPAC is upper case in both label and description Signed-off-by: David Nind <david@davidnind.com>
Created attachment 144181 [details] [review] Bug 32283: Correct capitalisation of opac > OPAC Test plan Step 1: Navigate to admin>Identity Providers Step 2: Add new domain Step 3: For 'Allow opac' setting, verify that opac is lower case in both label and description Step 4: Apply patch Step 5: Navigate to admin>Identity Providers Step 6: Add new domain Step 7: For 'Allow OPAC' setting, verify that OPAC is upper case in both label and description Signed-off-by: David Nind <david@davidnind.com>
Created attachment 144182 [details] [review] Bug 32283: (follow-up) Fix in two other places Fix two other occurences where the capitalization of OPAC is incorrect: - Identity provider email domains table column heading - 'New email domain' form label Signed-off-by: David Nind <david@davidnind.com>
I added a follow-up after signing off, I hope that is OK! Two fixes were required: - Identity provider email domains table column heading: should also be 'Allow OPAC'. - 'New email domain' form: the hint text is right, but the label is in lower case and should also be 'Allow OPAC'. Testing notes: 1. Go to Administration > Additional parameters > Identity providers. 2. Add a 'New identity provider' 3. Once added, select the 'Manage Domains' action for the identity provider. 4. Edit the existing "Identity provider email domains" entry: ==> after the patch is applied, OPAC is now in upper case for the 'Allow OPAC' label and hint text. 5. Note that for the "Identity provider email domains" table, the column heading is 'Allow opac' instead of 'Allow OPAC'. 6. Add a 'New email domain' got the identity provider, note that the label is 'Allow opac' (the hint text is correct).
I also noted that for the forms in koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_provider_domains.tt, the '<label for="allow_opac">' is used for the 'Allow staff' form field on lines 158 and 264. I don't know enough about these forms, but should that be '<label for="allow_staff">' instead?
I can fix those too. Should I do that under this bug? @David
(In reply to Andrew Auld from comment #9) > I can fix those too. Should I do that under this bug? @David Maybe better as a separate bug I think - as it is different from fixing the capitalisation.
Created attachment 144423 [details] [review] Bug 32283: Correct capitalisation of opac > OPAC Test plan Step 1: Navigate to admin>Identity Providers Step 2: Add new domain Step 3: For 'Allow opac' setting, verify that opac is lower case in both label and description Step 4: Apply patch Step 5: Navigate to admin>Identity Providers Step 6: Add new domain Step 7: For 'Allow OPAC' setting, verify that OPAC is upper case in both label and description Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 144424 [details] [review] Bug 32283: (follow-up) Fix in two other places Fix two other occurences where the capitalization of OPAC is incorrect: - Identity provider email domains table column heading - 'New email domain' form label Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.