Bug 32289 - Punctuation: Delete desk "...?"
Summary: Punctuation: Delete desk "...?"
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2022-11-19 17:59 UTC by Katrin Fischer
Modified: 2023-12-28 20:43 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.03,22.05.10


Attachments
Bug 32289: Fix punctuation in "Delete desk "X?" (1.23 KB, patch)
2023-02-05 01:46 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32289: Fix punctuation in "Delete desk "X?" (1.28 KB, patch)
2023-02-06 14:09 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32289: Fix punctuation in "Delete desk "X?" (1.34 KB, patch)
2023-02-06 15:45 UTC, Lucas Gass
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-11-19 17:59:32 UTC
koha-tmpl/intranet-tmpl/prog/en/modules/admin/desks.tt:        

<h1>Delete desk "[% desk.desk_name | html %]?"</h1>

The ending " should be before the question mark.
Comment 1 Katrin Fischer 2023-02-05 01:46:54 UTC
Created attachment 146187 [details] [review]
Bug 32289: Fix punctuation in "Delete desk "X?"

The question mark should be after the quote instead of before.

To test:
* Enable desks using the UseCirculationDesks system preference
* Go to administration > circulation desks
* Add a new desk and save
* Delete desk
* Verify the heading reads "Delete desk "X?"
* Apply patch
* Verify the punctuation now is fixed now
Comment 2 Owen Leonard 2023-02-06 14:09:41 UTC
Created attachment 146277 [details] [review]
Bug 32289: Fix punctuation in "Delete desk "X?"

The question mark should be after the quote instead of before.

To test:
* Enable desks using the UseCirculationDesks system preference
* Go to administration > circulation desks
* Add a new desk and save
* Delete desk
* Verify the heading reads "Delete desk "X?"
* Apply patch
* Verify the punctuation now is fixed now

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Lucas Gass 2023-02-06 15:45:59 UTC
Created attachment 146281 [details] [review]
Bug 32289: Fix punctuation in "Delete desk "X?"

The question mark should be after the quote instead of before.

To test:
* Enable desks using the UseCirculationDesks system preference
* Go to administration > circulation desks
* Add a new desk and save
* Delete desk
* Verify the heading reads "Delete desk "X?"
* Apply patch
* Verify the punctuation now is fixed now

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 Tomás Cohen Arazi 2023-02-06 21:35:48 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Matt Blenkinsop 2023-02-07 15:18:16 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 6 Lucas Gass 2023-02-15 13:09:35 UTC
Backported to 22.05.x for upcoming 22.05.10
Comment 7 Arthur Suzuki 2023-02-17 12:42:33 UTC
issue not present in 21.11.x
no need to backport :)