koha-tmpl/intranet-tmpl/prog/en/modules/admin/desks.tt: <h1>Delete desk "[% desk.desk_name | html %]?"</h1> The ending " should be before the question mark.
Created attachment 146187 [details] [review] Bug 32289: Fix punctuation in "Delete desk "X?" The question mark should be after the quote instead of before. To test: * Enable desks using the UseCirculationDesks system preference * Go to administration > circulation desks * Add a new desk and save * Delete desk * Verify the heading reads "Delete desk "X?" * Apply patch * Verify the punctuation now is fixed now
Created attachment 146277 [details] [review] Bug 32289: Fix punctuation in "Delete desk "X?" The question mark should be after the quote instead of before. To test: * Enable desks using the UseCirculationDesks system preference * Go to administration > circulation desks * Add a new desk and save * Delete desk * Verify the heading reads "Delete desk "X?" * Apply patch * Verify the punctuation now is fixed now Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 146281 [details] [review] Bug 32289: Fix punctuation in "Delete desk "X?" The question mark should be after the quote instead of before. To test: * Enable desks using the UseCirculationDesks system preference * Go to administration > circulation desks * Add a new desk and save * Delete desk * Verify the heading reads "Delete desk "X?" * Apply patch * Verify the punctuation now is fixed now Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x
Backported to 22.05.x for upcoming 22.05.10
issue not present in 21.11.x no need to backport :)