Bug 32290 - ILL requests uses some wrong terminology
Summary: ILL requests uses some wrong terminology
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Katrin Fischer
QA Contact: Martin Renvoize
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2022-11-19 18:04 UTC by Katrin Fischer
Modified: 2023-12-28 20:44 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.03,22.05.10,21.11.18


Attachments
Bug 32290: Fix terminology on ILL requests page (1.81 KB, patch)
2023-02-05 02:22 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32290: Fix terminology on ILL requests page (4.68 KB, patch)
2023-02-05 02:30 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32290: Fix terminology on ILL requests page (4.74 KB, patch)
2023-02-06 14:22 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32290: Fix terminology on ILL requests page (4.80 KB, patch)
2023-02-07 13:15 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-11-19 18:04:34 UTC
koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt:                                            <span class="required">You must choose a branch</span>

Branch should be library.
Comment 1 Katrin Fischer 2022-11-19 18:29:21 UTC
There is another in this template:

koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt:                        <div class="alert">This item cannot be issued as it has no biblio record associated with it</div>

* issued should be checked out
* biblio record should be replaced with bibliographic record
Comment 2 Katrin Fischer 2023-02-05 02:22:13 UTC
Created attachment 146189 [details] [review]
Bug 32290: Fix terminology on ILL requests page

This makes some fixes for the terminology used in
the ill-requests.pl page:

This item cannot be issued as it has no biblio record associated with it
> This item cannot be checkout out as there is no bibliographic record associated with it

You must choose a branch
> You must choose a library

View borrower details
> View patron details

Test plan:
* You can set up ILL using the instructions on
  https://wiki.koha-community.org/wiki/ILL_backends
* All strings will be located on the ILL request management page or
  the ILL requests list
* Or... you could verify looking at the patch itself
Comment 3 Katrin Fischer 2023-02-05 02:30:18 UTC
Created attachment 146190 [details] [review]
Bug 32290: Fix terminology on ILL requests page

This makes some fixes for the terminology used in
the ill-requests.pl page:

This item cannot be issued as it has no biblio record associated with it
> This item cannot be checkout out as there is no bibliographic record associated with it

You must choose a branch
> You must choose a library

View borrower details
> View patron details

Test plan:
* You can set up ILL using the instructions on
  https://wiki.koha-community.org/wiki/ILL_backends
* All strings will be located on the ILL request management page or
  the ILL requests list
* Or... you could verify looking at the patch itself
Comment 4 Owen Leonard 2023-02-06 14:22:57 UTC
Created attachment 146278 [details] [review]
Bug 32290: Fix terminology on ILL requests page

This makes some fixes for the terminology used in
the ill-requests.pl page:

This item cannot be issued as it has no biblio record associated with it
> This item cannot be checked out out as there is no bibliographic
  record associated with it

You must choose a branch
> You must choose a library

View borrower details
> View patron details

Test plan:
* You can set up ILL using the instructions on
  https://wiki.koha-community.org/wiki/ILL_backends
* All strings will be located on the ILL request management page or
  the ILL requests list
* Or... you could verify looking at the patch itself

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 5 Martin Renvoize 2023-02-07 13:15:15 UTC
Created attachment 146323 [details] [review]
Bug 32290: Fix terminology on ILL requests page

This makes some fixes for the terminology used in
the ill-requests.pl page:

This item cannot be issued as it has no biblio record associated with it
> This item cannot be checked out out as there is no bibliographic
  record associated with it

You must choose a branch
> You must choose a library

View borrower details
> View patron details

Test plan:
* You can set up ILL using the instructions on
  https://wiki.koha-community.org/wiki/ILL_backends
* All strings will be located on the ILL request management page or
  the ILL requests list
* Or... you could verify looking at the patch itself

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 6 Martin Renvoize 2023-02-07 13:15:39 UTC
Nice consistency improvements, PQA
Comment 7 Tomás Cohen Arazi 2023-02-07 13:51:35 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 8 Jacob O'Mara 2023-02-08 16:37:54 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 9 Lucas Gass 2023-02-15 21:15:55 UTC
Backported to 22.05.x for upcoming 22.05.10
Comment 10 Arthur Suzuki 2023-02-17 12:58:04 UTC
applied to 21.11.x for 21.11.18
Comment 11 wainuiwitikapark 2023-03-15 02:16:57 UTC
Not backported to 21.05.x