koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt: <span class="required">You must choose a branch</span> Branch should be library.
There is another in this template: koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt: <div class="alert">This item cannot be issued as it has no biblio record associated with it</div> * issued should be checked out * biblio record should be replaced with bibliographic record
Created attachment 146189 [details] [review] Bug 32290: Fix terminology on ILL requests page This makes some fixes for the terminology used in the ill-requests.pl page: This item cannot be issued as it has no biblio record associated with it > This item cannot be checkout out as there is no bibliographic record associated with it You must choose a branch > You must choose a library View borrower details > View patron details Test plan: * You can set up ILL using the instructions on https://wiki.koha-community.org/wiki/ILL_backends * All strings will be located on the ILL request management page or the ILL requests list * Or... you could verify looking at the patch itself
Created attachment 146190 [details] [review] Bug 32290: Fix terminology on ILL requests page This makes some fixes for the terminology used in the ill-requests.pl page: This item cannot be issued as it has no biblio record associated with it > This item cannot be checkout out as there is no bibliographic record associated with it You must choose a branch > You must choose a library View borrower details > View patron details Test plan: * You can set up ILL using the instructions on https://wiki.koha-community.org/wiki/ILL_backends * All strings will be located on the ILL request management page or the ILL requests list * Or... you could verify looking at the patch itself
Created attachment 146278 [details] [review] Bug 32290: Fix terminology on ILL requests page This makes some fixes for the terminology used in the ill-requests.pl page: This item cannot be issued as it has no biblio record associated with it > This item cannot be checked out out as there is no bibliographic record associated with it You must choose a branch > You must choose a library View borrower details > View patron details Test plan: * You can set up ILL using the instructions on https://wiki.koha-community.org/wiki/ILL_backends * All strings will be located on the ILL request management page or the ILL requests list * Or... you could verify looking at the patch itself Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 146323 [details] [review] Bug 32290: Fix terminology on ILL requests page This makes some fixes for the terminology used in the ill-requests.pl page: This item cannot be issued as it has no biblio record associated with it > This item cannot be checked out out as there is no bibliographic record associated with it You must choose a branch > You must choose a library View borrower details > View patron details Test plan: * You can set up ILL using the instructions on https://wiki.koha-community.org/wiki/ILL_backends * All strings will be located on the ILL request management page or the ILL requests list * Or... you could verify looking at the patch itself Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Nice consistency improvements, PQA
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.
Backported to 22.05.x for upcoming 22.05.10
applied to 21.11.x for 21.11.18
Not backported to 21.05.x