Bug 32291 - "library category" messages should be removed (not used)
Summary: "library category" messages should be removed (not used)
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Jonathan Druart
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 16735
Blocks:
  Show dependency treegraph
 
Reported: 2022-11-19 18:41 UTC by Katrin Fischer
Modified: 2023-12-28 20:44 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00, 22.11.01, 22.05.09, 21.11.16


Attachments
Bug 32291: (bug 16735 follow-up) Remove ref to library category in branches.tt (2.14 KB, patch)
2022-11-23 09:10 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32291: (bug 16735 follow-up) Remove ref to library category in branches.tt (2.19 KB, patch)
2022-12-02 13:10 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32291: (bug 16735 follow-up) Remove ref to library category in branches.tt (2.24 KB, patch)
2022-12-04 13:16 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-11-19 18:41:42 UTC
Also noticed a while ago, while translating. The errors mention library categories repeatedly, but I didn't figure out how to trigger those messages or what they were referring to. What is a library category and how can you add one?

The page is Administration > Libraries
koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt

        [% CASE 'error_on_update_category' %]
            <span>An error occurred when updating this library category. Perhaps it already exists.</span>
        [% CASE 'error_on_insert_category' %]
            <span>An error occurred when adding this library category. The categorycode might already exist.</span>
        [% CASE 'error_on_delete_category' %]
            <span>An error occurred when deleting this library category. Check the logs.</span>
        [% CASE 'success_on_update_category' %]
            <span>Library category updated successfully.</span>
        [% CASE 'success_on_insert_category' %]
            <span>Library category added successfully.</span>
        [% CASE 'success_on_delete_category' %]
            <span>Library category deleted successfully.</span>
        [% CASE 'cannot_delete_category' %]
            <span>This library category cannot be deleted. [% m.data.libraries_count | html %] libraries are still using it.</span>
Comment 1 Jonathan Druart 2022-11-23 09:07:03 UTC
This is coming from bug 16735 that forgot to remove those messages.
Comment 2 Jonathan Druart 2022-11-23 09:10:43 UTC
Created attachment 144191 [details] [review]
Bug 32291: (bug 16735 follow-up) Remove ref to library category in branches.tt

On bug 16735 we rewrite the library groups system. Those references in
branches.tt were part of the previous code, and they can be removed.

Test plan:
Confirm the above and that those code errors are never sent to the
template.
Comment 3 Owen Leonard 2022-12-02 13:10:35 UTC
Created attachment 144399 [details] [review]
Bug 32291: (bug 16735 follow-up) Remove ref to library category in branches.tt

On bug 16735 we rewrite the library groups system. Those references in
branches.tt were part of the previous code, and they can be removed.

Test plan:
Confirm the above and that those code errors are never sent to the
template.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 4 Katrin Fischer 2022-12-04 13:16:48 UTC
Created attachment 144425 [details] [review]
Bug 32291: (bug 16735 follow-up) Remove ref to library category in branches.tt

On bug 16735 we rewrite the library groups system. Those references in
branches.tt were part of the previous code, and they can be removed.

Test plan:
Confirm the above and that those code errors are never sent to the
template.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi 2022-12-07 17:30:51 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Matt Blenkinsop 2022-12-09 10:53:49 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 7 Matt Blenkinsop 2022-12-09 10:58:31 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 8 Lucas Gass 2023-01-18 21:33:59 UTC
Backported to 22.05.x for upcoming 22.05.09
Comment 9 Arthur Suzuki 2023-01-26 10:03:10 UTC
applied to 21.11.x for 21.11.16
Comment 10 wainuiwitikapark 2023-03-15 01:29:21 UTC
Not backported to 21.05.x