Bug 32294 - Capitalization: Enter your User ID...
Summary: Capitalization: Enter your User ID...
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Katrin Fischer
QA Contact: Lucas Gass
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2022-11-19 19:50 UTC by Katrin Fischer
Modified: 2023-12-28 20:44 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.03,22.05.10,21.11.18


Attachments
Bug 32294: Fix capitalization for user ID in self checkout (1.68 KB, patch)
2023-02-05 01:28 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32294: Fix capitalization for user ID in self checkout (1.73 KB, patch)
2023-02-06 14:01 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32294: Fix capitalization for user ID in self checkout (1.79 KB, patch)
2023-02-06 15:50 UTC, Lucas Gass
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-11-19 19:50:47 UTC
Web based self check help text:

Enter your User ID, and click the submit button (or press the enter key).

Should be: user ID

To test:
* Enable WebBasedSelfCheck 
* Go to: /cgi-bin/koha/sco/sco-main.pl in the OPAC
* Log in and open help
Comment 1 Katrin Fischer 2023-02-05 01:28:13 UTC
Created attachment 146185 [details] [review]
Bug 32294: Fix capitalization for user ID in self checkout

Fixes capitalization of "user ID" on the self checkout help
page.

To test:
* Enable WebBasedSelfCheck
* Go to: /cgi-bin/koha/sco/sco-main.pl in the OPAC
* Log in and open help
* Verify there is a User ID within a sentence and a User id in the heading
* Apply patch
* Both should be corrected
Comment 2 Owen Leonard 2023-02-06 14:01:33 UTC
Created attachment 146275 [details] [review]
Bug 32294: Fix capitalization for user ID in self checkout

Fixes capitalization of "user ID" on the self checkout help
page.

To test:
* Enable WebBasedSelfCheck
* Go to: /cgi-bin/koha/sco/sco-main.pl in the OPAC
* Log in and open help
* Verify there is a User ID within a sentence and a User id in the heading
* Apply patch
* Both should be corrected

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Lucas Gass 2023-02-06 15:50:40 UTC
Created attachment 146282 [details] [review]
Bug 32294: Fix capitalization for user ID in self checkout

Fixes capitalization of "user ID" on the self checkout help
page.

To test:
* Enable WebBasedSelfCheck
* Go to: /cgi-bin/koha/sco/sco-main.pl in the OPAC
* Log in and open help
* Verify there is a User ID within a sentence and a User id in the heading
* Apply patch
* Both should be corrected

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 Tomás Cohen Arazi 2023-02-06 21:35:56 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Matt Blenkinsop 2023-02-07 15:18:20 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 6 Lucas Gass 2023-02-15 13:11:57 UTC
Backported to 22.05.x for upcoming 22.05.10
Comment 7 Arthur Suzuki 2023-02-17 12:50:15 UTC
applied to 21.11.x for 21.11.18
Comment 8 wainuiwitikapark 2023-03-15 02:16:00 UTC
Not backported to 21.05.x