Bug 32295 - Punctuation: Filters :
Summary: Punctuation: Filters :
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Katrin Fischer
QA Contact: Martin Renvoize (ashimema)
URL: /cgi-bin/koha/serials/claims.pl
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2022-11-19 20:38 UTC by Katrin Fischer
Modified: 2023-12-28 20:44 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.03,22.05.10,21.11.18
Circulation function:

Attachments
Bug 32295: Fix punctuation for "Filters :" on serials claims page (1.36 KB, patch)
2023-02-05 01:40 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Bug 32295: Fix punctuation for "Filters :" on serials claims page (1.35 KB, patch)
2023-02-06 14:04 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 32295: Fix punctuation for "Filters :" on serials claims page (1.42 KB, patch)
2023-02-07 13:16 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-11-19 20:38:05 UTC 
On the late issues page for subscriptions, the heading is:

Filters :

But should be:

Filters:

To test:
* Add a subscription
* Generate next issue, to have a late one
* Go to serials > claims
* Select your vendor
Comment 1 Katrin Fischer 2023-02-05 01:40:25 UTC 
Created attachment 146186 [details] [review]
Bug 32295: Fix punctuation for "Filters :" on serials claims page

To test:
* Add a subscription
* Generate next issue, to have a late one
* Go to serials > claims
* Select your vendor
* Verify one of the sections is labelled "Filters :"
* Apply patch
* Verify the section is now labelled "Filters:"

https://bugs.koha-community.org/show_bug.cgi?id=28428
Comment 2 Owen Leonard 2023-02-06 14:04:30 UTC 
Created attachment 146276 [details] [review]
Bug 32295: Fix punctuation for "Filters :" on serials claims page

To test:
* Add a subscription
* Generate next issue, to have a late one
* Go to serials > claims
* Select your vendor
* Verify one of the sections is labelled "Filters :"
* Apply patch
* Verify the section is now labelled "Filters:"

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Martin Renvoize (ashimema) 2023-02-07 13:16:57 UTC 
Created attachment 146324 [details] [review]
Bug 32295: Fix punctuation for "Filters :" on serials claims page

To test:
* Add a subscription
* Generate next issue, to have a late one
* Go to serials > claims
* Select your vendor
* Verify one of the sections is labelled "Filters :"
* Apply patch
* Verify the section is now labelled "Filters:"

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize (ashimema) 2023-02-07 13:17:35 UTC 
PQA
Comment 5 Tomás Cohen Arazi (tcohen) 2023-02-07 13:51:41 UTC 
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Jacob O'Mara 2023-02-08 16:37:57 UTC 
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 7 Lucas Gass (lukeg) 2023-02-15 21:21:09 UTC 
Backported to 22.05.x for upcoming 22.05.10
Comment 8 Arthur Suzuki 2023-02-17 13:01:08 UTC 
applied to 21.11.x for 21.11.18