Table background_jobs should have indexes to optimize queries. Query on borrowernumber : mainpage.pl: my $already_ran_jobs = Koha::BackgroundJobs->search( mainpage.pl- { borrowernumber => $logged_in_user->borrowernumber } )->count ? 1 : 0; Query on status: misc/background_jobs_worker.pl: my $jobs = Koha::BackgroundJobs->search({ status => 'new', queue => \@queues });
Created attachment 144184 [details] [review] Bug 32330: Add indexes to table background_jobs Table background_jobs should have indexes to optimize queries. Query on borrowernumber : mainpage.pl: my $already_ran_jobs = Koha::BackgroundJobs->search( mainpage.pl- { borrowernumber => $logged_in_user->borrowernumber } )->count ? 1 : 0; Query on status: misc/background_jobs_worker.pl: my $jobs = Koha::BackgroundJobs->search({ status => 'new', queue => \@queues }); Test plan : Run updatedatabase and play with background jobs
Created attachment 144185 [details] [review] Bug 32330: Add indexes to table background_jobs Table background_jobs should have indexes to optimize queries. Query on borrowernumber : mainpage.pl: my $already_ran_jobs = Koha::BackgroundJobs->search( mainpage.pl- { borrowernumber => $logged_in_user->borrowernumber } )->count ? 1 : 0; Query on status: misc/background_jobs_worker.pl: my $jobs = Koha::BackgroundJobs->search({ status => 'new', queue => \@queues }); Test plan : Run updatedatabase and play with background jobs
Created attachment 144186 [details] [review] Bug 32330: Add indexes to table background_jobs Table background_jobs should have indexes to optimize queries. Query on borrowernumber : mainpage.pl: my $already_ran_jobs = Koha::BackgroundJobs->search( mainpage.pl- { borrowernumber => $logged_in_user->borrowernumber } )->count ? 1 : 0; Query on status and queue : misc/background_jobs_worker.pl: my $jobs = Koha::BackgroundJobs->search({ status => 'new', queue => \@queues }); Test plan : Run updatedatabase and play with background jobs
Created attachment 144390 [details] [review] Bug 32330: Add indexes to table background_jobs Table background_jobs should have indexes to optimize queries. Query on borrowernumber : mainpage.pl: my $already_ran_jobs = Koha::BackgroundJobs->search( mainpage.pl- { borrowernumber => $logged_in_user->borrowernumber } )->count ? 1 : 0; Query on status and queue : misc/background_jobs_worker.pl: my $jobs = Koha::BackgroundJobs->search({ status => 'new', queue => \@queues }); Test plan : Run updatedatabase and play with background jobs Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Good call
Created attachment 144493 [details] [review] Bug 32320: Remove text-shadow from header menu links This patch unsets the text-shadow style on links in the header menu. This makes the links look a little crisper. The style is inherited from Bootstrap's defaults and is incorrect for our design. To test, apply the patch and rebuild the staff interface CSS. View any page in the staff interface to confirm that header menu links look correct. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment on attachment 144493 [details] [review] Bug 32320: Remove text-shadow from header menu links Wrong bug number, sorry!
Created attachment 144638 [details] [review] Bug 32330: Add indexes to table background_jobs Table background_jobs should have indexes to optimize queries. Query on borrowernumber : mainpage.pl: my $already_ran_jobs = Koha::BackgroundJobs->search( mainpage.pl- { borrowernumber => $logged_in_user->borrowernumber } )->count ? 1 : 0; Query on status and queue : misc/background_jobs_worker.pl: my $jobs = Koha::BackgroundJobs->search({ status => 'new', queue => \@queues }); Test plan : Run updatedatabase and play with background jobs Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Nice, Frido.
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to 22.11.x for the next release
Backported to 22.05.x for upcoming 22.05.09
applied to 21.11.x for 21.11.16
Today, while upgrading a koha-common (21.11.16-1) over (21.11.13-1), the process crash with: Upgrade to 21.11.15.001 [12:03:24]: Bug 32330 - Add indexes to background_jobs table ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Key column 'queue' doesn't exist in table at /usr/share/koha/lib/C4/Installer.pm line 739 queue is not present on background_jobs on 21.11: https://schema.koha-community.org/21_11/tables/background_jobs.html There is a workaround? This reveals a QA flaw?
Arf indeed, background_job.queue has been added by Bug 27783 in 22.05.00 I contact RMaint of 21.11.x
(In reply to Pablo AB from comment #14) > Upgrade to 21.11.15.001 [12:03:24]: Bug 32330 - Add indexes to > background_jobs table > ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Key column > 'queue' doesn't exist in table at /usr/share/koha/lib/C4/Installer.pm line > 739 > > queue is not present on background_jobs on 21.11: > https://schema.koha-community.org/21_11/tables/background_jobs.html > > There is a workaround? We just released a hot-fix 21.11.17. Thanks for reporting it. > This reveals a QA flaw? This patch was intended for 22.11 and 22.05, probably a communication problem. Best regards
Reverted the 'queue' portion of this dev, on 21.11.x.
Not backported to 21.05.x